After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684475 - Potential infinite loop in migrate_account_to_uoa
Potential infinite loop in migrate_account_to_uoa
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: UOA
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-20 12:59 UTC by Guillaume Desmottes
Modified: 2012-09-21 06:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
migrate_account_to_uoa: actually iterate over the supersedes array (1.33 KB, patch)
2012-09-20 13:02 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-09-20 12:59:18 UTC 
supersedes = tp_account_get_supersedes (account);
  while (*supersedes != NULL)
    tp_account_request_add_supersedes (ar, *supersedes);
Comment 1 Guillaume Desmottes 2012-09-20 13:02:45 UTC 
Created attachment 224831 [details] [review]
migrate_account_to_uoa: actually iterate over the supersedes array

I'm not a fan of pointer arithmetic, it's clearer to iterate using an index.
Comment 2 Xavier Claessens 2012-09-20 13:13:30 UTC 
+1
Comment 3 Guillaume Desmottes 2012-09-21 06:46:50 UTC 
Attachment 224831 [details] pushed as 25c6dfd - migrate_account_to_uoa: actually iterate over the supersedes array