After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684459 - Session not locked when switching user via user Menu
Session not locked when switching user via user Menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-20 11:29 UTC by darkxst
Modified: 2012-10-07 08:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
userMenu: Close menu immediately on user/session switch (889 bytes, patch)
2012-09-20 21:20 UTC, Florian Müllner
committed Details | Review

Description darkxst 2012-09-20 11:29:25 UTC
When switching users the lock screen is not activated. I can switch between the different users VT's without any screenshield/lock appearing on any of them.

Steps to reproduce
1. Click Switch User in the User Menu
2. Login as a different user
3. Ctl-Alt F7 and get back to an unlocked session of the first users session.

This is with
gnome-shell + gdm 3.5.92
Comment 1 Matthias Clasen 2012-09-20 12:14:29 UTC
I do get a screenshield, but it is buggy as well. Here is what is happening for me:

1. Select 'switch user from the user menu'
2. Get to the login screen
3. Select my old session again
4. Come back to the screen shield. The user menu is open on top of the screen shield, on the left side where my name is in the panel.
Comment 2 Matthias Clasen 2012-09-20 18:11:31 UTC
trying to reproduce, the unlock is generally working. I do see the shield for a bit after coming back, because of vt switching blocking gl, I guess. So that part is somewhat unfixable.

It is a bug though that the user menu shows up on top of the shield, at the left.
Can we make it so that we unmap the menu before vt switching ?

A proposal to make things look less assy, by Ray:

- lift the shield properly on Unlock, don't just pop it out of existence

- drop the shield before vt switching on the login screen

This could also fix the 'default background shows through issue that we have with normal login.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-20 21:12:44 UTC
(In reply to comment #2)
> trying to reproduce, the unlock is generally working. I do see the shield for a
> bit after coming back, because of vt switching blocking gl, I guess. So that
> part is somewhat unfixable.
> 
> It is a bug though that the user menu shows up on top of the shield, at the
> left.
> Can we make it so that we unmap the menu before vt switching ?

Florian should have fixed that bug.

https://bugzilla.gnome.org/show_bug.cgi?id=684343
Comment 4 Florian Müllner 2012-09-20 21:16:55 UTC
(In reply to comment #3)
> > It is a bug though that the user menu shows up on top of the shield, at the
> > left.
> > Can we make it so that we unmap the menu before vt switching ?
> 
> Florian should have fixed that bug.
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=684343

Nope. The fix should be pretty much identical though.
Comment 5 Florian Müllner 2012-09-20 21:20:09 UTC
Created attachment 224862 [details] [review]
userMenu: Close menu immediately on user/session switch

The same reasoning as for commit 1f30670c1d8d8 also applies to
VT switches.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-09-20 21:26:17 UTC
Review of attachment 224862 [details] [review]:

Obviously right.
Comment 7 darkxst 2012-09-20 21:28:21 UTC
Except in my case the screenShield is never activated on user switch.
Comment 8 Florian Müllner 2012-09-20 21:33:18 UTC
It is addressing the issue Matthias noted in comment #1. What's happening in your case needs more investigation.
Comment 9 Matthias Clasen 2012-09-21 00:09:29 UTC
Do you want to go for a freeze break for this ?
The lock screen being a shiny new feature, people are probably going to play with it in .0, and discover this kind of oddity...
Comment 10 drago01 2012-09-21 12:01:51 UTC
(In reply to comment #9)
> Do you want to go for a freeze break for this ?
> The lock screen being a shiny new feature, people are probably going to play
> with it in .0, and discover this kind of oddity...

I'd say yes.
Comment 11 Matthias Clasen 2012-09-21 12:59:20 UTC
I'll give my +1 here, and ask for the second on the list.
Comment 12 Matthias Clasen 2012-09-21 14:05:53 UTC
fredp gave the second +1 on the list, go ahead.
Comment 13 Florian Müllner 2012-09-21 14:08:55 UTC
Comment on attachment 224862 [details] [review]
userMenu: Close menu immediately on user/session switch

Attachment 224862 [details] pushed as 3429fc3 - userMenu: Close menu immediately on user/session switch

Leaving bug open, as the patch does not address the originally reported problem (though so far nobody has been able to reproduce it).
Comment 14 darkxst 2012-10-07 08:06:31 UTC
Seems to be fixed, probably from the fix in https://bugzilla.gnome.org/show_bug.cgi?id=685536