GNOME Bugzilla – Bug 684447
Missing highlight utility prevents displaying attachments inside mail message
Last modified: 2013-09-13 01:07:09 UTC
Apparently attachments are generated using highlight utility. Not having that utility prevents displaying the attachments inline: "Failed to load part '.message.mixed.1.text-highlight.plain_text.0'"
Created attachment 224826 [details] [review] Patch This patch adds a initial check for presence of 'highlight' utility. If the utility is not present, the text-highlight module is not registered to Evolution at all. It also adds a fallback mode so that in case 'highlight' would crash/fail or magically disappear the text-highlight module falls back to native text/plain formatter to display the content of the part without highlighting.
Created attachment 226074 [details] [review] Updated patch As per discussion with Matt on IRC, this patch enforces build-time check for presence of the highlight utility, rather then runtime check. I left the part to fallback to text/plain formatter in case highlight utility fails or crashes so that the content is still delivered to the user.
Committed fix for Evolution 3.7 as 5437fa7c354b5ddf12b4e13136834d86168e3580 http://git.gnome.org/browse/evolution/commit/?id=5437fa7c354b5ddf12b4e13136834d86168e3580 Cherry-picked the run-time check to gnome-3-6 as d0734298d21c5a59ed408910b552d7c4ffa79577 http://git.gnome.org/browse/evolution/commit/?h=gnome-3-6&id=d0734298d21c5a59ed408910b552d7c4ffa79577