After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684444 - schemas: Add lockdown mode key for user-accounts
schemas: Add lockdown mode key for user-accounts
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 681762
 
 
Reported: 2012-09-20 09:17 UTC by Ondrej Holy
Modified: 2012-11-22 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add lockdown mode key for user-accounts (1.04 KB, patch)
2012-09-20 09:17 UTC, Ondrej Holy
needs-work Details | Review
add lockdown mode key for user-accounts (1.08 KB, patch)
2012-10-04 07:56 UTC, Ondrej Holy
needs-work Details | Review
add lockdown mode key for user-accounts (1.10 KB, patch)
2012-10-04 11:52 UTC, Ondrej Holy
accepted-commit_now Details | Review

Description Ondrej Holy 2012-09-20 09:17:12 UTC
Created attachment 224820 [details] [review]
add lockdown mode key for user-accounts

Adding lockdown mode key for user-accounts is necessary for:

https://bugzilla.gnome.org/show_bug.cgi?id=681762
Comment 1 Bastien Nocera 2012-09-25 11:43:50 UTC
I don't think that's how we want to frame the lockdown though.

Something like "disable-account-editing"? Stef?
Comment 2 Bastien Nocera 2012-09-25 11:44:42 UTC
Review of attachment 224820 [details] [review]:

As per comment.
Comment 3 Stef Walter 2012-09-26 08:24:46 UTC
This doesn't (or shouldn't disable all editing of ones own account). So let's not use the word 'editing'. Also we could avoid a double-negative for clarity.

Perhaps something like 'user-admin-enabled', defaulting to 'true'?
Comment 4 Ondrej Holy 2012-10-04 07:56:24 UTC
Created attachment 225775 [details] [review]
add lockdown mode key for user-accounts
Comment 5 Bastien Nocera 2012-10-04 10:46:26 UTC
Review of attachment 225775 [details] [review]:

etc.

::: schemas/org.gnome.desktop.lockdown.gschema.xml.in.in
@@ +63,3 @@
       </_description>
     </key>
+    <key name="user-admin-enabled" type="b">

user-administration-disabled

@@ +64,3 @@
     </key>
+    <key name="user-admin-enabled" type="b">
+      <default>true</default>

false

@@ +67,3 @@
+      <_summary>Enable user accounts</_summary>
+      <_description>
+        Allow the user modifying user accounts. For example, this would

Stop the user from modifying user accounts. By default, we allow adding and removing users, as well as changing other users settings.
Comment 6 Ondrej Holy 2012-10-04 11:52:51 UTC
Created attachment 225798 [details] [review]
add lockdown mode key for user-accounts
Comment 7 Bastien Nocera 2012-11-18 10:31:21 UTC
Review of attachment 225798 [details] [review]:

++