After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684440 - Port embedded view source mode to WebKit2
Port embedded view source mode to WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-09-20 09:01 UTC by Carlos Garcia Campos
Modified: 2013-01-04 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.46 KB, patch)
2012-12-31 14:10 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-09-20 09:01:24 UTC 
WebKit2 doesn't have API to set the WebView in view source mode.
Comment 1 Carlos Garcia Campos 2012-10-15 13:08:58 UTC 
See https://bugs.webkit.org/show_bug.cgi?id=99315
Comment 2 Carlos Garcia Campos 2012-12-31 14:10:25 UTC 
Created attachment 232432 [details] [review]
Patch

The WebKit patch landed, but I noticed of another issue while implementing this, so we need another patch for this work:

https://bugs.webkit.org/show_bug.cgi?id=105885
Comment 3 Carlos Garcia Campos 2013-01-02 17:41:13 UTC 
(In reply to comment #2)
> Created an attachment (id=232432) [details] [review]
> Patch
> 
> The WebKit patch landed, but I noticed of another issue while implementing
> this, so we need another patch for this work:
> 
> https://bugs.webkit.org/show_bug.cgi?id=105885

This is fixed now
Comment 4 Xan Lopez 2013-01-03 16:11:42 UTC 
Review of attachment 232432 [details] [review]:

Looks good.