After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684379 - In RTL locals, the titles of searched contents must aligned to right.
In RTL locals, the titles of searched contents must aligned to right.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-19 14:38 UTC by Ibrahim Saed
Modified: 2012-09-21 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The titles must aligned to right (602.50 KB, image/png)
2012-09-19 14:38 UTC, Ibrahim Saed 		  Details
searchDisplay: Fix alignment of section headers in RTL locales (1.04 KB, patch)
2012-09-19 15:05 UTC, Florian Müllner 		committed Details | Review

Description Ibrahim Saed 2012-09-19 14:38:31 UTC 
Created attachment 224756 [details]
The titles must aligned to right

In right to left locales (v3.5.92), the titles of searched contents displayed in left side (see the attached screenshot).

These titles must aligned to right.
Comment 1 Florian Müllner 2012-09-19 15:05:19 UTC 
Created attachment 224760 [details] [review]
searchDisplay: Fix alignment of section headers in RTL locales
Comment 2 Rui Matos 2012-09-19 15:19:07 UTC 
Review of attachment 224760 [details] [review]:

Looks good. Not sure if it's worth the code freeze break but it's so simple that it can easily go in IMO.
Comment 3 Florian Müllner 2012-09-19 15:32:16 UTC 
(In reply to comment #2)
> Looks good. Not sure if it's worth the code freeze break but it's so simple
> that it can easily go in IMO.

Right, if the bug had been filed just an hour earlier :-)
(or we had released an hour later of course)

I think it is OK to have it in .1, which tends to be the version shipped by distributions ...
Comment 4 Matthias Clasen 2012-09-21 17:52:05 UTC 
Javier gave a +1. I guess I will give you the second one, so go ahead if you want.
Comment 5 André Klapper 2012-09-21 18:10:39 UTC 
Yes please, get this in for 3.6.0. :)
Comment 6 Florian Müllner 2012-09-21 19:04:55 UTC 
Attachment 224760 [details] pushed as 175ddaa - searchDisplay: Fix alignment of section headers in RTL locales

Yes, but I was commuting home when I got the OK :-)