After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684378 - search-provider: Add volume mounts only if mounted
search-provider: Add volume mounts only if mounted
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-19 14:24 UTC by Yanko Kaneti
Modified: 2012-09-19 16:59 UTC
See Also:
GNOME target: 3.6
GNOME version: ---

Attachments
search-provider: Add volume mounts only if mounted (1.57 KB, patch)
2012-09-19 14:24 UTC, Yanko Kaneti 		accepted-commit_after_freeze Details | Review
search-provider: Add volume mounts only if mounted (1.56 KB, patch)
2012-09-19 15:36 UTC, Yanko Kaneti 		committed Details | Review

Description Yanko Kaneti 2012-09-19 14:24:46 UTC 
Add volume mounts to search only if mounted
Comment 1 Yanko Kaneti 2012-09-19 14:24:48 UTC 
Created attachment 224750 [details] [review]
search-provider: Add volume mounts only if mounted
Comment 2 Yanko Kaneti 2012-09-19 14:34:33 UTC 
Its also a crash prevention measure. Currently 3.5.92 search provider crashes on me 2 letters into the search entry with:

(nautilus-shell-search-provider:29799): GLib-GIO-CRITICAL **: g_mount_get_name: assertion `G_IS_MOUNT (mount)' failed
Segmentation fault (core dumped)

its g_mount_get_name-> NULL -> g_utf8_normalize
Comment 3 Cosimo Cecchi 2012-09-19 15:21:36 UTC 
Review of attachment 224750 [details] [review]:

Thanks for the patch, looks good. I'm going to request a hard code freeze break for this.
Comment 4 Yanko Kaneti 2012-09-19 15:36:09 UTC 
Created attachment 224765 [details] [review]
search-provider: Add volume mounts only if mounted
Comment 5 Cosimo Cecchi 2012-09-19 16:59:37 UTC 
Attachment 224765 [details] pushed as cfe7a09 - search-provider: Add volume mounts only if mounted

Pushed after r-t approval