After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684358 - gio-2.0: DBusConnection is missing the "closed" signal
gio-2.0: DBusConnection is missing the "closed" signal
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 684522 772424 (view as bug list)
Depends on: 731547
Blocks:
 
 
Reported: 2012-09-19 08:18 UTC by Rico Tzschichholz
Modified: 2017-06-07 06:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio-2.0: Fix DBusConnection `closed` signal binding (1.92 KB, patch)
2017-05-24 14:01 UTC, Ole André Vadla Ravnås 		none Details | Review
gio-2.0: Fix DBusConnection `closed` signal binding (1.92 KB, patch)
2017-05-24 14:02 UTC, Ole André Vadla Ravnås 		none Details | Review
gio-2.0: Add DBusConnection 'closed' signal as 'closed_signal' (1.54 KB, patch)
2017-06-06 15:47 UTC, Rico Tzschichholz 		none Details | Review
gio-2.0: Add DBusConnection 'closed' signal as 'on_closed' (1.53 KB, patch)
2017-06-06 21:27 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2012-09-19 08:18:43 UTC 
As the title says the binding of DbusConnection in gio-2.0.vapi is missing a binding for the "closed" signal. This is probably caused by a name-clash with another method/property.
Comment 1 Evan Nemerson 2012-09-21 09:03:38 UTC 
*** Bug 684522 has been marked as a duplicate of this bug. ***
Comment 2 Chandni Verma 2012-09-21 12:05:03 UTC 
I see there are such instances with many other vapis too. For instance the telepathy-glib vapi also has for Channel class, a close_async() instead of a close signal.
Comment 3 Rico Tzschichholz 2017-03-08 13:57:59 UTC 
*** Bug 772424 has been marked as a duplicate of this bug. ***
Comment 4 Ole André Vadla Ravnås 2017-05-24 14:01:28 UTC 
Created attachment 352499 [details] [review]
gio-2.0: Fix DBusConnection `closed` signal binding

The property is shadowing it, and is accessible through `is_closed()` anyway.
Comment 5 Ole André Vadla Ravnås 2017-05-24 14:02:19 UTC 
Created attachment 352500 [details] [review]
gio-2.0: Fix DBusConnection `closed` signal binding

The property is shadowing it, and is accessible through `is_closed()` anyway.
Comment 6 Rico Tzschichholz 2017-06-06 15:47:38 UTC 
Created attachment 353270 [details] [review]
gio-2.0: Add DBusConnection 'closed' signal as 'closed_signal'

It was masked by property with same name.
Comment 7 Evan Nemerson 2017-06-06 19:02:53 UTC 
Review of attachment 353270 [details] [review]:

Instead of "closed_signal", how about "connection_closed", or even "on_closed"?
Comment 8 Rico Tzschichholz 2017-06-06 21:27:01 UTC 
Created attachment 353276 [details] [review]
gio-2.0: Add DBusConnection 'closed' signal as 'on_closed'

It was masked by property with same name.
Comment 9 Rico Tzschichholz 2017-06-07 06:16:43 UTC 
Attachment 353276 [details] pushed as dea6a4a - gio-2.0: Add DBusConnection 'closed' signal as 'on_closed'