After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684354 - Make properties for / more useful
Make properties for / more useful
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-19 07:45 UTC by William Jon McCann
Modified: 2012-09-25 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show capacity chart for local disk (1.22 KB, patch)
2012-09-19 07:45 UTC, William Jon McCann 		committed Details | Review
Don't show volume info for things without a volume (3.45 KB, patch)
2012-09-19 07:45 UTC, William Jon McCann 		committed Details | Review
Use helper function to determine if file is root (1.09 KB, patch)
2012-09-25 16:53 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-09-19 07:45:25 UTC 
Currently we don't show much that is useful in the properties dialog for /.

We should show the usage chart and not show Volume and Location.
Comment 1 William Jon McCann 2012-09-19 07:45:27 UTC 
Created attachment 224705 [details] [review]
Show capacity chart for local disk
Comment 2 William Jon McCann 2012-09-19 07:45:29 UTC 
Created attachment 224706 [details] [review]
Don't show volume info for things without a volume
Comment 3 Cosimo Cecchi 2012-09-19 15:16:48 UTC 
Review of attachment 224705 [details] [review]:

Looks good.
Comment 4 Cosimo Cecchi 2012-09-19 15:20:11 UTC 
Review of attachment 224706 [details] [review]:

::: src/nautilus-properties-window.c
@@ +2454,3 @@
+
+	return result;
+

Can the previous patch also use this helper function?

@@ +2610,3 @@
+
+	return FALSE;
+

And maybe also this? The duplication between this and should_show_volume_usage() is a little unfortunate.
Comment 5 William Jon McCann 2012-09-25 16:25:15 UTC 
Attachment 224705 [details] pushed as e1577b1 - Show capacity chart for local disk
Attachment 224706 [details] pushed as e478a3e - Don't show volume info for things without a volume
Comment 6 William Jon McCann 2012-09-25 16:53:52 UTC 
Created attachment 225143 [details] [review]
Use helper function to determine if file is root
Comment 7 William Jon McCann 2012-09-25 16:54:06 UTC 
Attachment 225143 [details] pushed as d85be64 - Use helper function to determine if file is root