After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684351 - rpc-layer: Fix memory leak in call state pool
rpc-layer: Fix memory leak in call state pool
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: pkcs11
3.5.x
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-19 07:13 UTC by Stef Walter
Modified: 2012-09-25 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rpc-layer: Fix memory leak in call state pool (941 bytes, patch)
2012-09-19 07:13 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-09-19 07:13:38 UTC 
The pool of CallState objects in the gnome-keyring-pkcs11.so module
was causing what looked like a memory leak to valgrind.
Comment 1 Stef Walter 2012-09-19 07:13:41 UTC 
Created attachment 224704 [details] [review]
rpc-layer: Fix memory leak in call state pool
Comment 2 Stef Walter 2012-09-19 07:13:56 UTC 
See https://bugs.freedesktop.org/show_bug.cgi?id=46722 for more details.
Comment 3 g.trentalancia 2012-09-19 16:23:18 UTC 
Hello Stef.

Thanks for proposing a solution to the problem. Perhaps, it might have a security impact that needs to be classified in CVE database for example ?

I am sorry, but unfortunately my test system is temporarily knocked down due to problems with other components that were getting radically changed, so I am not able to test your proposed changes at the moment.

If and when I will be able to test, I will let you know.
Comment 4 Stef Walter 2012-09-19 16:37:16 UTC 
I don't think this is a security vulnerability. The leak is not cumulative. And the pooled connection just connects back to the same user session daemon.
Comment 5 Stef Walter 2012-09-25 14:00:38 UTC 
Attachment 224704 [details] pushed as 0c71452 - rpc-layer: Fix memory leak in call state pool