GNOME Bugzilla – Bug 68435
Update to fribidi 0.10
Last modified: 2004-12-22 21:47:04 UTC
The current fribidi code in Pango is quite old (April 2001), and we should merge up to the recently released 0.10. It's a reasonable amount of work because: - The layout of the code has changed a lot - There are some problems with the current fribidi code with excessive relocations that should be fixed before merging into Pango, this requires changes to the generate-tables utilities.
I don't expect to get to this before Pango 1.0.0... it's quite a bit of work.
Suspect this is a 1.2 job at this point.
the latest fribidi is at http://fribidi.sourceforge.net/
Might depend on bug 114749 depending on what is decided there.
Created attachment 18289 [details] [review] patch (using fribidi HEAD as of 2003-07-14) (warning, 400k)
This patch depends on the patch in bug 114749
Created attachment 18397 [details] [review] patch, same as the last one, but tables updated to unicode 4.0 (fribidi cvs still uses 3.2)
FriBidi CVS should not be used, as it has a context patch which is not tested heavily yet. BTW, I vote for delaying the patch until the new fribidi is released, which makes it quite easy to import it into pango. If you use the STABLE branch from CVS, which is the same as the latest release 0.10.4, it has Unicode 4 tables.
Behdad and I looked at the patch. We tested the fribidi test files against, and there was no change in rendering as compared with without the patch applied. So it works at least nominally. 2003-11-20 Noah Levitt <nlevitt@columbia.edu> * pango/pango-utils.c: * pango/mini-fribidi/Makefile.am: * pango/mini-fribidi/README: * pango/mini-fribidi/fribidi.c: * pango/mini-fribidi/fribidi.patch: * pango/mini-fribidi/fribidi_char_type.c: * pango/mini-fribidi/fribidi_tab_char_type_2.i: * pango/mini-fribidi/fribidi_types.c: * pango/mini-fribidi/fribidi_types.h: * pango/mini-fribidi/fribidi_types.i: Update to latest fribidi. (#68435)