After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684342 - screenShield: Delay destruction of unlock dialog
screenShield: Delay destruction of unlock dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-19 02:39 UTC by Florian Müllner
Modified: 2012-09-19 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenShield: Delay destruction of unlock dialog (1.34 KB, patch)
2012-09-19 02:39 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-09-19 02:39:36 UTC 
See patch.
Comment 1 Florian Müllner 2012-09-19 02:39:39 UTC 
Created attachment 224685 [details] [review]
screenShield: Delay destruction of unlock dialog

While the unlock dialog is created early so that it appears below
the shield while the curtain slides up, it is destroyed immediately
when the shield slides back in.
Keep it around until the shield is down instead.
Comment 2 drago01 2012-09-19 08:15:07 UTC 
Review of attachment 224685 [details] [review]:

LG.
Comment 3 Florian Müllner 2012-09-19 10:07:51 UTC 
Attachment 224685 [details] pushed as 114f6f5 - screenShield: Delay destruction of unlock dialog
Comment 4 Giovanni Campagna 2012-09-19 10:54:15 UTC 
Uh, this patch is wrong!
It doesn't consider ._isGreeter, and will destroy the LoginDialog too.
Comment 5 Florian Müllner 2012-09-19 11:16:32 UTC 
Pushed a fix, thanks.