After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684333 - grilo: fix reference counting
grilo: fix reference counting
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-18 23:06 UTC by Giovanni Campagna
Modified: 2012-09-18 23:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grilo: fix reference counting (1.29 KB, patch)
2012-09-18 23:06 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-09-18 23:06:15 UTC 
The sources hash table in the plugin wants to take ownership of the key and
the value, but the key is owned by the GrlRegistry and the value is a GtkWidget
and thus floating. Fix that by referencing both before adding them to the
hash table.
Comment 1 Giovanni Campagna 2012-09-18 23:06:18 UTC 
Created attachment 224679 [details] [review]
grilo: fix reference counting
Comment 2 Jonathan Matthew 2012-09-18 23:11:17 UTC 
Review of attachment 224679 [details] [review]:

yes.
Comment 3 Giovanni Campagna 2012-09-18 23:14:58 UTC 
Attachment 224679 [details] pushed as 03c7fd8 - grilo: fix reference counting