Bug 684329 - msg: Add an option to set a custom dialog icon
msg: Add an option to set a custom dialog icon
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-09-18 21:03 UTC by Florian Müllner
Modified: 2012-09-25 23:32 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
msg: Add an option to set a custom dialog icon (8.94 KB, patch)
2012-09-18 21:03 UTC, Florian Müllner 		none Details | Diff | Review
msg: Add an option to set a custom dialog icon (8.95 KB, patch)
2012-09-19 12:27 UTC, Florian Müllner 		accepted-commit_now Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Florian Müllner 2012-09-18 21:03:11 UTC 
See patch.
Comment 1 Florian Müllner 2012-09-18 21:03:13 UTC 
Created attachment 224674 [details] [review]
msg: Add an option to set a custom dialog icon

The predefined dialog icons work well in many cases, but sometimes
it makes sense to use a more specific icon, so add an option to
specify an icon-name to use instead.
Comment 2 William Jon McCann 2012-09-19 03:36:27 UTC 
This would be really useful to be able to set the icon we use in the "window not responding" dialogs. Would be very helpful to get this in.
Comment 3 Florian Müllner 2012-09-19 12:27:30 UTC 
Created attachment 224745 [details] [review]
msg: Add an option to set a custom dialog icon

Wooops, last patch had a jolly mix of --icon and --icon-name; pick the latter.
Comment 4 Matthias Clasen 2012-09-25 12:20:16 UTC 
Arx, still time to do a 3.6.0 release with this patch today
Comment 5 Colin Walters 2012-09-25 15:05:31 UTC 
Review of attachment 224745 [details] [review]:

Patch tested and works here in jhbuild.
Comment 6 Matthias Clasen 2012-09-25 16:16:46 UTC 
+1 from me for the release team
Comment 7 Matthias Clasen 2012-09-25 23:32:41 UTC 
Pushed without the string addition for now, since I wasn't getting replies from
the translators. Please revert the commit that takes out the strings once you
branch for 3.6.
Note You need to log in before you can comment on or make changes to this bug.