GNOME Bugzilla – Bug 684327
setting null icon to icon list
Last modified: 2013-08-18 01:55:09 UTC
When we can't determine the mime type of a file it seems we are prepending a null icon name. gvfs-info davs://192.168.1.105:5006/Documents/README display name: README edit name: README name: README size: 0 attributes: standard::name: README standard::display-name: README standard::edit-name: README standard::icon: (null), application-octet-stream, gnome-mime-application-octet-stream, application-x-generic, text-x-generic
Created attachment 224669 [details] [review] Don't write nulls into icon list
Review of attachment 224669 [details] [review]: The cleanup looks nice, but doesn't this also change the order? As far as I can see, previously we had: - xdg mimetype icon (if exists) - mimetype icon (always exists) - legacy mimetype icon (always exists) - generic mimetype icon (if exists) Whereas after this patch we have: - xdg mimetype icon - generic mimetype icon - mimetype icon - legacy mimetype icon
Created attachment 224686 [details] [review] Don't write nulls into icon list
We should also consider dropping the gnome-mime- legacy names. It's been a while...
Review of attachment 224686 [details] [review]: AFAICS this still changes the order, as it puts the legacy gnome- mimetype icon last (we used to have the generic XDG icon last instead). I think dropping the legacy gnome- icon names could be fine, but I think I'd rather do it at the beginning of next cycle and just fix the reported bug here.
Seeing that we didn't get this done last cycle I guess we can just remove the legacy names now?
Created attachment 233626 [details] [review] Remove legacy icon name support
Comment on attachment 224686 [details] [review] Don't write nulls into icon list commit 936254c386b57ee61ccbba3fac659fc631a9cc9a Author: Alexander Larsson <alexl@redhat.com> Date: Fri Nov 30 09:39:13 2012 +0100 Don't look for icons called "(null)" if no xdg mime icon
Attachment 233626 [details] pushed as b0e6a38 - Remove legacy icon name support