After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684327 - setting null icon to icon list
setting null icon to icon list
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-09-18 20:30 UTC by William Jon McCann
Modified: 2013-08-18 01:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't write nulls into icon list (2.92 KB, patch)
2012-09-18 20:31 UTC, William Jon McCann
reviewed Details | Review
Don't write nulls into icon list (2.90 KB, patch)
2012-09-19 02:47 UTC, William Jon McCann
none Details | Review
Remove legacy icon name support (2.30 KB, patch)
2013-01-16 20:08 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-09-18 20:30:58 UTC
When we can't determine the mime type of a file it seems we are prepending a null icon name.

gvfs-info davs://192.168.1.105:5006/Documents/README 
display name: README
edit name: README
name: README
size:  0
attributes:
  standard::name: README
  standard::display-name: README
  standard::edit-name: README
  standard::icon: (null), application-octet-stream, gnome-mime-application-octet-stream, application-x-generic, text-x-generic
Comment 1 William Jon McCann 2012-09-18 20:31:45 UTC
Created attachment 224669 [details] [review]
Don't write nulls into icon list
Comment 2 Cosimo Cecchi 2012-09-18 21:57:28 UTC
Review of attachment 224669 [details] [review]:

The cleanup looks nice, but doesn't this also change the order?

As far as I can see, previously we had:
- xdg mimetype icon (if exists)
- mimetype icon (always exists)
- legacy mimetype icon (always exists)
- generic mimetype icon (if exists)

Whereas after this patch we have:
- xdg mimetype icon
- generic mimetype icon
- mimetype icon
- legacy mimetype icon
Comment 3 William Jon McCann 2012-09-19 02:47:44 UTC
Created attachment 224686 [details] [review]
Don't write nulls into icon list
Comment 4 Matthias Clasen 2012-09-19 11:43:08 UTC
We should also consider dropping the gnome-mime- legacy names.
It's been a while...
Comment 5 Cosimo Cecchi 2012-09-19 14:50:25 UTC
Review of attachment 224686 [details] [review]:

AFAICS this still changes the order, as it puts the legacy gnome- mimetype icon last (we used to have the generic XDG icon last instead).
I think dropping the legacy gnome- icon names could be fine, but I think I'd rather do it at the beginning of next cycle and just fix the reported bug here.
Comment 6 William Jon McCann 2013-01-16 18:57:20 UTC
Seeing that we didn't get this done last cycle I guess we can just remove the legacy names now?
Comment 7 William Jon McCann 2013-01-16 20:08:32 UTC
Created attachment 233626 [details] [review]
Remove legacy icon name support
Comment 8 William Jon McCann 2013-01-16 20:09:09 UTC
Comment on attachment 224686 [details] [review]
Don't write nulls into icon list

commit 936254c386b57ee61ccbba3fac659fc631a9cc9a
Author: Alexander Larsson <alexl@redhat.com>
Date:   Fri Nov 30 09:39:13 2012 +0100

    Don't look for icons called "(null)" if no xdg mime icon
Comment 9 Matthias Clasen 2013-08-18 01:55:05 UTC
Attachment 233626 [details] pushed as b0e6a38 - Remove legacy icon name support