Created attachment 224663 [details] [review]
util: Add an option to request dialogs being modal

As WMs cannot open windows themselves, Mutter uses zenity to open
"Force Quit" dialogs for unresponsive windows; as those are strongly
tied to the corresponding window, it makes sense to make them modal
(in particular when attaching them to their parent).

I think we really want this for 3.6. It makes a lot of sense to have the "*This* window is not responding" attached to the window in question. It also makes sense to dim out the non responding window as we do for modals.

That's a great patch! I wish more people contribute with zenity like this. I'll test when I came home and if everything it's okay, I'll commit (need to check the string freeze as well).

Thanks!

Thanks! The patch does of course break the string freeze (the description for the new option), though we could leave it untranslated for now to get around the freeze ...

Arx, can we get this in for the release? We're already a bit overdue.

Ping?

If you are going to do 3.6 tarballs, this would still help tremendously to make gnome-shell's "Force Quit" dialog look less crappy :-)

Arx, still time to do a 3.6.0 release with this patch today

Review of attachment 224663 [details] [review]:

Looks reasonable.  I'll wait for the zenity maintainer to mark as reviewed, but this is RT 1/2

::: src/util.c
@@ +433,3 @@
   g_assert (gtk_widget_get_window(dialog));
+  zenity_util_make_transient (gtk_widget_get_window(dialog),
+                              !!g_object_get_data (G_OBJECT (dialog), "modal"));

Funky...but I guess other zenity code does stuff like this.  It looks OK.

Created attachment 225141 [details] [review]
util: Add an option to request dialogs being modal

Oh, the funkyness was actually a workaround, a quick test with the new iteration suggests that it is no longer needed \o/

Cool! I'll review and commit in a few hours. Right now I'm mobile. Give me 2 hours :)

+1 from me for the release team.

Pushed without the string addition for now, since I wasn't getting replies from the translators. Please revert the commit that takes out the strings once you branch for 3.6.