Created attachment 224657 [details] [review]
daemon: Clean up error handling for gdm_server_spawn()

This fixes a bug where we'd try to call g_child_watch_add() on a 0
pid in case of error.  More importantly, this moves us closer to
a sane error handling story where the default is to throw.

Created attachment 224658 [details] [review]
server: Ensure log/auth directories exist at startup

The daemon startup had lots of swapping around of effective uid, and
aborted if the log/auth directories didn't have the expected permissions.

Honestly this makes no sense - we're uid 0, so let's just ensure
they're directories and call chown() ourself.  I have no idea what the
"paranoia" here is about - if someone had managed to e.g. make a
symbolic link in /var to somewhere unexpected, there are plenty of
other ways they could attack the system.

Rather than aborting, let's just call mkdir()/chown()/chmod() and
check the return values.

never have to ask permission to push a wip branch