After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684304 - [PATCH] Crash in monitor_entry_file()
[PATCH] Crash in monitor_entry_file()
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
2.97
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-18 16:01 UTC by Michael Terry
Modified: 2012-09-18 23:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.66 KB, patch)
2012-09-18 16:21 UTC, Michael Terry 		none Details | Review

Description Michael Terry 2012-09-18 16:01:04 UTC 
This is a bug reported in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1029333

With stack trace:
https://launchpadlibrarian.net/111199789/Stacktrace.txt

It looks to me like db->priv->library_locations might be NULL there?

I have two possible suggestions after looking at the code:

1) Guard the loop in monitor_entry_file() by checking if library_locations is NULL.

2) In rhythmdb_shutdown(), call rhythmdb_stop_monitoring() before setting library_locations to NULL.
Comment 1 Michael Terry 2012-09-18 16:21:08 UTC 
Created attachment 224643 [details] [review]
Proposed patch
Comment 2 Jonathan Matthew 2012-09-18 22:00:07 UTC 
I think the real problem here is that rhythmdb_stop_monitoring doesn't cancel _monitor_entry_thread.
Comment 3 Jonathan Matthew 2012-09-18 22:53:40 UTC 
I can't really see a good reason for that thread to exist, so I'm going to remove it entirely.
Comment 4 Jonathan Matthew 2012-09-18 23:00:46 UTC 
commit 7fd3e2d removes the thread.