After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684288 - level-bar: add an "inverted" property like GtkProgressBar
level-bar: add an "inverted" property like GtkProgressBar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-09-18 12:08 UTC by Stefano Facchini
Modified: 2012-10-17 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
level-bar: add an "inverted" property like GtkProgressBar (9.18 KB, patch)
2012-09-18 12:08 UTC, Stefano Facchini
none Details | Review
test program (2.49 KB, text/plain)
2012-09-18 12:10 UTC, Stefano Facchini
  Details
level-bar: add an "inverted" property like GtkProgressBar (9.16 KB, patch)
2012-09-18 12:27 UTC, Stefano Facchini
none Details | Review
level-bar: add support for RTL locales (951 bytes, patch)
2012-09-18 12:28 UTC, Stefano Facchini
committed Details | Review
Add gdk version macros for 3.8 (1.03 KB, patch)
2012-09-19 11:43 UTC, Stefano Facchini
committed Details | Review
level-bar: add an "inverted" property like GtkProgressBar (9.32 KB, patch)
2012-09-19 11:43 UTC, Stefano Facchini
reviewed Details | Review
level-bar: add an "inverted" property like GtkProgressBar (9.96 KB, patch)
2012-09-27 14:01 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2012-09-18 12:08:48 UTC
For next cycle
Comment 1 Stefano Facchini 2012-09-18 12:08:51 UTC
Created attachment 224611 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar
Comment 2 Stefano Facchini 2012-09-18 12:10:32 UTC
Created attachment 224612 [details]
test program
Comment 3 Stefano Facchini 2012-09-18 12:27:41 UTC
Created attachment 224613 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Fixed silliness
Comment 4 Stefano Facchini 2012-09-18 12:28:19 UTC
Created attachment 224614 [details] [review]
level-bar: add support for RTL locales
Comment 5 Matthias Clasen 2012-09-19 01:39:18 UTC
Both very reasonable ideas.
The first patch is missing Since: 3.8 and GDK_AVAILABLE_IN_3_8
Comment 6 Stefano Facchini 2012-09-19 11:43:04 UTC
Created attachment 224735 [details] [review]
Add gdk version macros for 3.8
Comment 7 Stefano Facchini 2012-09-19 11:43:27 UTC
Created attachment 224736 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar
Comment 8 Cosimo Cecchi 2012-09-19 19:31:00 UTC
Review of attachment 224736 [details] [review]:

Looks fine overall - the new symbols should also be added to docs/reference/gtk/gtk3-sections.txt

::: gtk/gtklevelbar.c
@@ +307,3 @@
 gtk_level_bar_draw_fill_continuous (GtkLevelBar           *self,
                                     cairo_t               *cr,
+                                    gboolean               inverted,

No need to pass inverted down to all methods, since it's available in self->priv.

@@ +1277,3 @@
+ * @self: a #GtkLevelBar
+ *
+ * Gets the value set by gtk_level_bar_set_inverted().

"Returns the value of the inverted property" to be consistent with the other methods.

@@ +1294,3 @@
+ * gtk_level_bar_set_inverted:
+ * @self: a #GtkLevelBar
+gboolean

progress bar -> level bar

@@ +1296,3 @@
+ * @inverted: %TRUE to invert the progress bar
+ *
+gtk_level_bar_get_inverted (GtkLevelBar *self)

"Sets the value of the inverted property", and move the documentation of what the property does to its gtk-doc block in class_init.
Comment 9 Cosimo Cecchi 2012-09-19 19:32:09 UTC
Review of attachment 224614 [details] [review]:

Sounds good - now I also understand why you pass inverted down to the draw methods, so you can ignore that previous comment :)
Comment 10 Cosimo Cecchi 2012-09-19 19:32:30 UTC
Review of attachment 224735 [details] [review]:

Fine to commit with the other patches.
Comment 11 Stefano Facchini 2012-09-27 14:01:53 UTC
Created attachment 225259 [details] [review]
level-bar: add an "inverted" property like GtkProgressBar

Fixed the issues spotted by Cosimo
Comment 12 Cosimo Cecchi 2012-09-27 16:00:47 UTC
Review of attachment 225259 [details] [review]:

Looks good to commit after GTK is branched for 3.6.
Comment 13 Stefano Facchini 2012-10-17 12:26:36 UTC
Attachment 224614 [details] pushed as 5e55bf1 - level-bar: add support for RTL locales
Attachment 224735 [details] pushed as 0f36b16 - Add gdk version macros for 3.8
Attachment 225259 [details] pushed as e5de18c - level-bar: add an "inverted" property like GtkProgressBar