GNOME Bugzilla – Bug 684280
RFE: jump to the shortcut settings from link directly
Last modified: 2012-09-21 19:47:17 UTC
There are a link to the shortcut settings on the input sources tab though, that would be intuitive and give us a good experience if it jumps to "Typing" section in the shortcut settings directly.
Works correctly here, and jumps to the correct tab. Any special way to reproducing the problem? Which versions did you test with?
The request is to jump directly to the Typing section I think.
Oh, right. Yes, we could do that actually.
Created attachment 224608 [details] [review] keyboard: Allow switching to a specific section
Created attachment 224609 [details] [review] region: Switch to the input sources section When clicking on the link.
Review of attachment 224609 [details] [review]: ++
Review of attachment 224608 [details] [review]: Looks good. Just some cosmetic nits below. ::: panels/keyboard/keyboard-shortcuts.c @@ +669,3 @@ append_sections_from_gsettings (builder); /* Select the first item */ This comment is wrong now. @@ +678,3 @@ + selection = gtk_tree_view_get_selection (section_treeview); + gtk_tree_selection_select_iter (selection, &iter); + } I know the code style is inconsistent in g-c-c but this file uses braces-on-their-own-line everywhere else. @@ +1811,3 @@ + + builder = g_object_get_data (G_OBJECT (panel), "builder"); + if (builder == NULL) { braces
Created attachment 224627 [details] [review] keyboard: Allow switching to a specific section
Created attachment 224630 [details] [review] keyboard: Allow switching to a specific section
Created attachment 224631 [details] [review] region: Switch to the input sources section When clicking on the link.
Review of attachment 224630 [details] [review]: See the comment below, up to you if you want to split this or go with the previous approach. ::: panels/keyboard/keyboard-shortcuts.c @@ +73,3 @@ { SECTION_DESCRIPTION_COLUMN, + SECTION_ID_COLUMN, This would be better, but I think it should go in a separate patch before this one. Also, if we want to do this, I think we should also change the kb_*_sections hash tables to use this ID instead of the translated description. And in section_selection_changed() we could then also use the ID instead of the description to match the Typing section to add the XKB options.
Created attachment 224650 [details] [review] keyboard: Add unique IDs for each shortcuts section Rather than relying on comparison of translated strings.
Created attachment 224651 [details] [review] keyboard: Add ability to switch to a shortcuts section With some new API.
Created attachment 224652 [details] [review] keyboard: Handle arguments for the shortcuts tab So it's possible to switch directly to a section of the shortcuts tab, rather than have users look for particular sections when redirected there through a link.
Review of attachment 224650 [details] [review]: Yes
Review of attachment 224651 [details] [review]: Looks good
Review of attachment 224652 [details] [review]: Fine
Review of attachment 224631 [details] [review]: ++
A bit confusing that we have a 'Typing' tab, and a 'Typing' section in the 'Shortcuts' tab. But the patches look fine to me, otherwise.
Pushed all those patches by mistake while fixing another bug. Reopen if I should revert them.
Attachment 224631 [details] pushed as c8b4efd - region: Switch to the input sources section