After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684241 - PAM prompts at unlock screen are in wrong locale
PAM prompts at unlock screen are in wrong locale
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-17 18:25 UTC by Ray Strode [halfline]
Modified: 2012-09-18 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
worker: Copy environment from login session to reauth sessions (4.64 KB, patch)
2012-09-17 19:20 UTC, Ray Strode [halfline]
none Details | Review
worker: Copy environment from login session to reauth sessions (52.08 KB, patch)
2012-09-17 20:41 UTC, Ray Strode [halfline]
committed Details | Review
worker: correct debug messages (1.54 KB, patch)
2012-09-17 20:41 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2012-09-17 18:25:01 UTC
GDM currently doesn't properly set the users environment variables in reauth sessions so we don't show unlock prompts in the right locale.  See

https://mail.gnome.org/archives/gnome-shell-list/2012-September/msg00096.html
Comment 1 Ray Strode [halfline] 2012-09-17 19:20:31 UTC
Created attachment 224546 [details] [review]
worker: Copy environment from login session to reauth sessions

Reauthentication sessions depend on having the same environment
as the session they were initiated from.  This is important to
make sure login prompts are in the right language, to make sure
the kerberos credentials cache is looked up, and for various
other reasons.

This commit copies the environment from the login session to
any new reauthentication sessions that get started after login.
Comment 2 Ray Strode [halfline] 2012-09-17 19:20:47 UTC
(untested patch, will test it shortly)
Comment 3 Ray Strode [halfline] 2012-09-17 20:41:26 UTC
I did some testing and reworked the patch.

The following fixes have been pushed:
6d5dd09 worker: Copy environment from login session to reauth sessions
dfce196 worker: correct debug messages
Comment 4 Ray Strode [halfline] 2012-09-17 20:41:31 UTC
Created attachment 224553 [details] [review]
worker: Copy environment from login session to reauth sessions

Reauthentication sessions depend on having the same environment
as the session they were initiated from.  This is important to
make sure login prompts are in the right language, to make sure
the kerberos credentials cache is looked up, and for various
other reasons.

This commit copies the environment from the login session to
any new reauthentication sessions that get started after login.
Comment 5 Ray Strode [halfline] 2012-09-17 20:41:33 UTC
Created attachment 224554 [details] [review]
worker: correct debug messages

The conversation-started message said "stopped" and the
conversation-stopped message said "started"

This commit flips 'em.
Comment 6 Ray Strode [halfline] 2012-09-18 14:09:41 UTC
(see https://mail.gnome.org/archives/gnome-shell-list/2012-September/msg00096.html for the thread that prompted this bug)
Comment 7 Ray Strode [halfline] 2012-09-18 14:09:58 UTC
oh i already said that in comment 0