After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684220 - wizard: Continue button becomes sensitive while nothing is selected
wizard: Continue button becomes sensitive while nothing is selected
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-17 13:57 UTC by Fabiano Fidêncio
Modified: 2016-03-31 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Select entry if its ClickedFunc returns true (3.58 KB, patch)
2012-10-08 21:07 UTC, Zeeshan Ali 		committed Details | Review
wizard: Unselect entry when going from URL to main page (1.45 KB, patch)
2012-10-08 21:07 UTC, Zeeshan Ali 		committed Details | Review

Description Fabiano Fidêncio 2012-09-17 13:57:59 UTC 
Steps to reproduce:
In Source Selection Screen
1 - Click in "Select a file"
2 - In the File Selector, lick in "Cancel"

At this point, Continue button is activated, but should be only if an ISO image was selected.
Comment 1 Christophe Fergeau 2012-09-17 14:58:26 UTC 
I cannot reproduce this one. Are you testing this right after starting boxes, or did you do something else first ?
Comment 2 Fabiano Fidêncio 2012-09-17 15:03:07 UTC 
(In reply to comment #1)
> I cannot reproduce this one. Are you testing this right after starting boxes,
> or did you do something else first ?

I'm testing right after starting Boxes.
Comment 3 Zeeshan Ali 2012-09-30 20:35:38 UTC 
I'm able to reproduce this here.
Comment 4 Zeeshan Ali 2012-10-08 21:07:00 UTC 
Created attachment 226075 [details] [review]
wizard: Select entry if its ClickedFunc returns true

This fixes the bug of 'Continue' button becoming sensitive if you cancel
the file selection dialog.
Comment 5 Zeeshan Ali 2012-10-08 21:07:03 UTC 
Created attachment 226076 [details] [review]
wizard: Unselect entry when going from URL to main page

If you follow these steps, 'Continue' becomes sensitive:

1. Type something in the entry on URL page
2. Go back to main page
3. Go to URL page
4. Remove all text from entry
5. Repeat 2 and 3 again

This patch fixes the problem by simply unsetting the current selection
when going back from URL to main page. IMHO this makes sense anyways
since on main page the URL is not shown so user doesn't know what would
'Continue' imply. Note that with this patch, 'Continue' becomes
sensitive again if you go to URL page and there is text entered already
in there.

NOTE: We probably should be doing some more checks on URLs before
enabling the 'Continue' button rather than simply checking non-zero
length string.
Comment 6 Christophe Fergeau 2012-10-11 09:38:35 UTC 
Review of attachment 226075 [details] [review]:

Looks good
Comment 7 Christophe Fergeau 2012-10-11 10:00:42 UTC 
Review of attachment 226076 [details] [review]:

I tested it a bit, and this seems ok
Comment 8 Zeeshan Ali 2012-10-11 12:21:27 UTC 
Attachment 226075 [details] pushed as 2f2bc20 - wizard: Select entry if its ClickedFunc returns true
Attachment 226076 [details] pushed as d7fdde7 - wizard: Unselect entry when going from URL to main page