After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684218 - still says "Loading..." if there is a problem loading
still says "Loading..." if there is a problem loading
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-17 13:41 UTC by William Jon McCann
Modified: 2012-09-25 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (37.81 KB, image/png)
2012-09-17 13:41 UTC, William Jon McCann 		  Details
slot: ensure the floating bar is hidden when loading finishes (1.14 KB, patch)
2012-09-19 04:19 UTC, Cosimo Cecchi 		committed Details | Review
slot: consolidate code for showing/hiding the loading floating bar (12.92 KB, patch)
2012-09-19 04:20 UTC, Cosimo Cecchi 		committed Details | Review

Description William Jon McCann 2012-09-17 13:41:30 UTC 
Created attachment 224508 [details]
screenshot

The statusbar still says "Loading..." if there is a problem loading.
Comment 1 Cosimo Cecchi 2012-09-19 04:19:52 UTC 
Created attachment 224694 [details] [review]
slot: ensure the floating bar is hidden when loading finishes

Since in case of loading error we don't go through the same code path
than in case of success; by using the connection to the end_loading
signal, we can ensure the floating bar is removed also in case of error.
Comment 2 Cosimo Cecchi 2012-09-19 04:20:14 UTC 
Created attachment 224695 [details] [review]
slot: consolidate code for showing/hiding the loading floating bar

Move all the code relative to it in NautilusWindowSlot, and make the
relative object members private.
Comment 3 Cosimo Cecchi 2012-09-25 15:24:09 UTC 
Attachment 224694 [details] pushed as 6c5b8dc - slot: ensure the floating bar is hidden when loading finishes
Attachment 224695 [details] pushed as 0b22ba6 - slot: consolidate code for showing/hiding the loading floating bar