After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684207 - user-accounts: Default LocalAccount property to TRUE
user-accounts: Default LocalAccount property to TRUE
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 683822 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-17 12:23 UTC by Stef Walter
Modified: 2012-09-18 22:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Default LocalAccount property to TRUE (1.19 KB, patch)
2012-09-17 12:23 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-09-17 12:23:15 UTC 
Make gnome-control-center easier to test with non-up-to-date AccountsService
that doesn't have the LocalAccount property on users. (ie: earlier than 0.6.24)
Comment 1 Stef Walter 2012-09-17 12:23:17 UTC 
Created attachment 224497 [details] [review]
user-accounts: Default LocalAccount property to TRUE

 * When loading properties from the AccountsService we may encounter
   an implementation that does not yet have the LocalAccount property.
 * Default the LocalAccount property to TRUE so things work correctly
   in the above case.
Comment 2 Bastien Nocera 2012-09-17 13:18:57 UTC 
Review of attachment 224497 [details] [review]:

Remove the asterisks from the commit message please.

::: panels/user-accounts/um-user.c
@@ +108,3 @@
         }
 
+        /* Add some defaults that may not be received from some AccountsService versions */

Maybe a link to the bug itself?
Comment 3 Bastien Nocera 2012-09-17 17:24:54 UTC 
Attachment 224497 [details] pushed as 0721469 - user-accounts: Default LocalAccount property to TRUE
Comment 4 Bastien Nocera 2012-09-18 22:31:06 UTC 
*** Bug 683822 has been marked as a duplicate of this bug. ***