After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684157 - configure --enable-frequency-selector non functional
configure --enable-frequency-selector non functional
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cpufreq
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-16 17:52 UTC by Dominique Leuenberger
Modified: 2013-07-21 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Support --{enable,disable }-frequency-selector (914 bytes, patch)
2012-09-20 07:52 UTC, Dominique Leuenberger
committed Details | Review

Description Dominique Leuenberger 2012-09-16 17:52:58 UTC
configure --enable-frequency-selector does not work as expected, and has the same effect as --disable-frequency-selector;
the only way currently to enable the frequency selector is not to specify enable/disable at all.

The issue in configure.in is rather 'clear':
dnl --enable-frequency-selector=(yes/no)
AC_ARG_ENABLE(frequency-selector,
              [  --enable-frequency-selector[@<:@=yes/no@:>@]
                          build frequency selector [@<:@default: yes@:>@]], ,
              enable_selector=yes)

there is a  mis-match between 'frequency-selector' and 'selector' variables, which results in this mismatch.

I'll see if I can come up with a nice patch without changing configure too mutch.
Comment 1 Dominique Leuenberger 2012-09-20 07:52:01 UTC
Created attachment 224811 [details] [review]
Support --{enable,disable }-frequency-selector
Comment 2 Dominique Leuenberger 2013-02-08 19:55:45 UTC
Are the -applets considered dead to not care anymore for such patches?
If they are, we could/should close bugs, even as trivial as this one, as wontfix / obsolete.
Comment 3 Jeremy Bicha 2013-07-21 16:27:41 UTC
Yes, gnome-applets and gnome-panel are unmaintained which means that it's
unlikely that anyone would even come around to close bugs.

See also https://wiki.gnome.org/GnomeFlashback You could easily get maintainer
access if you wanted to take charge.