After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684154 - wanda flickers
wanda flickers
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-16 17:15 UTC by Matthias Clasen
Modified: 2012-09-17 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
IconGrid: don't recreate the texture if the icon size doesn't change (786 bytes, patch)
2012-09-16 17:36 UTC, Giovanni Campagna 		rejected Details | Review
Wanda: don't recreate the texture if the icon size doesn't change (2.07 KB, patch)
2012-09-16 18:30 UTC, Giovanni Campagna 		needs-work Details | Review
Wanda: don't recreate the texture if the icon size doesn't change (1.02 KB, patch)
2012-09-17 14:22 UTC, Giovanni Campagna 		committed Details | Review
Wanda: remove unnecessary destroy signal connection (1.60 KB, patch)
2012-09-17 14:22 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2012-09-16 17:15:59 UTC 
if you have wanda in the search results, and hover on and off with the mouse, she blinks in and out of existence.
Comment 1 Giovanni Campagna 2012-09-16 17:36:41 UTC 
Created attachment 224449 [details] [review]
IconGrid: don't recreate the texture if the icon size doesn't change

This avoids a flicker in the Wanda search provider.
Comment 2 Giovanni Campagna 2012-09-16 17:37:10 UTC 
Nominating this a blocker: we can't ship without working Wanda.
Comment 4 drago01 2012-09-16 17:42:57 UTC 
Review of attachment 224449 [details] [review]:

Somehow Jasper's review does not show up in the bug but see http://git.gnome.org/browse/gnome-shell/commit/js/ui/iconGrid.js?id=b833aff3c826ff23bf91a7be2e194365731af864
Comment 5 drago01 2012-09-16 17:43:29 UTC 
(In reply to comment #4)
> Review of attachment 224449 [details] [review]:
> 
> Somehow Jasper's review does not show up in the bug but see
> http://git.gnome.org/browse/gnome-shell/commit/js/ui/iconGrid.js?id=b833aff3c826ff23bf91a7be2e194365731af864

OK now it does sorry for the noise ...
Comment 6 Giovanni Campagna 2012-09-16 18:30:34 UTC 
Created attachment 224453 [details] [review]
Wanda: don't recreate the texture if the icon size doesn't change

Wanda flickers if the animation is recreated, but we don't need to if
the size doesn't change (as we're not affected by icon theme changes).
Also, remove the destroy signal connection, which was unnecessary and
caused exceptions.
Comment 7 drago01 2012-09-17 07:31:41 UTC 
Review of attachment 224453 [details] [review]:

Looks good but the destroy signal removal should be a separate patch.
Comment 8 Giovanni Campagna 2012-09-17 14:22:22 UTC 
Created attachment 224512 [details] [review]
Wanda: don't recreate the texture if the icon size doesn't change

Wanda flickers if the animation is recreated, but we don't need to if
the size doesn't change (as we're not affected by icon theme changes).
Comment 9 Giovanni Campagna 2012-09-17 14:22:55 UTC 
Created attachment 224513 [details] [review]
Wanda: remove unnecessary destroy signal connection

'destroy' is emitted before the actor is unmapped during destruction, so
notify::mapped would emit an exception. Since unmapping is guaranteed,
the 'destroy' signal is unnecessary.
Comment 10 drago01 2012-09-17 14:44:44 UTC 
Review of attachment 224512 [details] [review]:

Looks good.
Comment 11 drago01 2012-09-17 14:45:16 UTC 
Review of attachment 224513 [details] [review]:

Looks good.
Comment 12 Giovanni Campagna 2012-09-17 17:51:51 UTC 
Attachment 224512 [details] pushed as 70c34ba - Wanda: don't recreate the texture if the icon size doesn't change
Attachment 224513 [details] pushed as 4beba79 - Wanda: remove unnecessary destroy signal connection