GNOME Bugzilla – Bug 684058
Introspection is ignored for properties defined in parent classes if the child isn't introspected
Last modified: 2012-09-24 07:51:59 UTC
Created attachment 224376 [details] [review] pygi-property: Lookup property in base classes of non-introspected types If in a base class I define some property as a "GLib.List(MyType)" and I subclass it in a plugin. Then the pygobject will fail to find the data because it ignore parent classes if the plugin isn't introspected. Attached is a patch that will just go up the tree of GTypes even if the child isn't introspected.
Thanks for this! Do you have a (preferably really small) reproducer for this, which we can develop a test case from?
We already have some tests which check accessing the parent class' properties that are defined from Python: http://git.gnome.org/browse/pygobject/tree/tests/test_properties.py#n599 I now added a test case which checks the parent class properties which are defined in C: http://git.gnome.org/browse/pygobject/commit/?id=a047f61 but that already works fine. So I'll wait for your reproducer. Thanks!
Created attachment 224531 [details] [review] test_properties: Test property that requires introspection to be used
Comment on attachment 224376 [details] [review] pygi-property: Lookup property in base classes of non-introspected types Ah, thanks! I'll reshuffle the second patch so that it becomes a new test case instead of changing an existing one (I think the existing one is still good to have). We are in hard code freeze ATM, this will go into master and 3.4.1 after the GNOME 3.6 release.
Created attachment 224576 [details] [review] pygi-property: Lookup property in base classes of non-introspected types This provides a separate test case in test_everything.py (which exercises Regress) and joins the patch and test case. Thanks!
Comment on attachment 224576 [details] [review] pygi-property: Lookup property in base classes of non-introspected types Committed. Fix will be in 3.4.1.