After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684036 - MessageTray: remove bad fast path in hideSummaryBoxPointer
MessageTray: remove bad fast path in hideSummaryBoxPointer
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-14 16:20 UTC by Giovanni Campagna
Modified: 2012-09-14 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MessageTray: remove bad fast path in hideSummaryBoxPointer (1.39 KB, patch)
2012-09-14 16:20 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-09-14 16:20:00 UTC 
The onUngrab callback already checks if all notifications are destroyed and
hides immediately if so. Previous code instead would leave state handling
in an inconsistent state, by not removing the grab, not setting
summaryBoxPointerState to HIDDEN and not disconnecting various signals.
Comment 1 Giovanni Campagna 2012-09-14 16:20:03 UTC 
Created attachment 224347 [details] [review]
MessageTray: remove bad fast path in hideSummaryBoxPointer
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-14 16:22:39 UTC 
Review of attachment 224347 [details] [review]:

OK.
Comment 3 Giovanni Campagna 2012-09-14 16:31:58 UTC 
Attachment 224347 [details] pushed as 7654f1c - MessageTray: remove bad fast path in hideSummaryBoxPointer