GNOME Bugzilla – Bug 684029
universal access: missing colon in zoom options ui
Last modified: 2021-06-09 16:31:34 UTC
The grayscale slider in the "Color effects" tab is labelled "Color". Other sliders in the dialog append a colon after their label, e.g., "Brightness:". For consistency, the label on the grayscale slider should be "Color:".
Created attachment 224337 [details] [review] Adds a colon to the gray scale slider label.
Created attachment 226438 [details] [review] Adds colon, ':', to 'Color' label on gray scale slider There have been modifications to the zoom-options.ui file since the previous patch was uploaded. This patch takes those changes into account.
Review of attachment 226438 [details] [review]: This isn't right. There's a number of places where you're using colons in the dialogue and you shouldn't. Headings shouldn't have colons for example. I'll let Allan review this though.
All the other labels have colons there, so this seems good to me. Maybe we need to review the use of colons more generally, but that doesn't need to block this.
(In reply to comment #4) > All the other labels have colons there, so this seems good to me. > > Maybe we need to review the use of colons more generally, but that doesn't need > to block this. That would make it look very inconsistent, IMO, and I'd like this fixed properly.
In 3.24 Brightness doesn’t have a colon either, but Contrast does. Labels for sliders in the crosshairs tab of the zoom settings have colons. It seems labels for sliders everywhere else don't have colons. I failed to find anything relevant in the HIG. Allan, can you advise?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.