After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683985 - Try to unsubscribe from the proxy used for subscription
Try to unsubscribe from the proxy used for subscription
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-13 19:49 UTC by William Jon McCann
Modified: 2012-09-13 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Try to unsubscribe from the proxy used for subscription (8.81 KB, patch)
2012-09-13 19:49 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-09-13 19:49:12 UTC 
Currently when a file monitor is disposed we try to cancel it. This then tries
to find a connection and proxy on which to unsubscribe. If there are no
refs to those they won't be around anymore and weird things happen. 
It is better to keep a ref to the proxy instead.
Comment 1 William Jon McCann 2012-09-13 19:49:14 UTC 
Created attachment 224264 [details] [review]
Try to unsubscribe from the proxy used for subscription

This makes cancel much cleaner and solves a problem
where we were trying to use a previously disposed proxy.
Comment 2 Alexander Larsson 2012-09-13 20:00:23 UTC 
Attachment 224264 [details] pushed as be11520 - Try to unsubscribe from the proxy used for subscription