After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683982 - lookingGlass: Fix object inspector for multi-monitor scenarios
lookingGlass: Fix object inspector for multi-monitor scenarios
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-13 18:47 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-09-16 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lookingGlass: Fix object inspector for multi-monitor scenarios (2.41 KB, patch)
2012-09-13 18:47 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-09-13 18:47:48 UTC
See patch. This removes the fancy part where the object inspector zooms
from the link that was clicked, but I don't think anybody really cares
about that.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-09-13 18:47:50 UTC
Created attachment 224257 [details] [review]
lookingGlass: Fix object inspector for multi-monitor scenarios

Otherwise the object inspector appears off-screen.
Comment 2 Giovanni Campagna 2012-09-13 19:16:47 UTC
Review of attachment 224257 [details] [review]:

Are the two changes necessary together?
Or can you have the position fix without the anchor point change?

(acn if yes)
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-13 19:20:38 UTC
Review of attachment 224257 [details] [review]:

The pivot point change was just to make it zoom from the center rather than the top left. I was lazy to actually do the math to calculate where we need to zoom from. I fiddled around a bit and couldn't get anything right. But the other two fixes are necessary together, yes.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-09-16 20:38:41 UTC
Attachment 224257 [details] pushed as 0d62ec5 - lookingGlass: Fix object inspector for multi-monitor scenarios