After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683979 - atk-adaptor: plug some refcount leaks
atk-adaptor: plug some refcount leaks
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-atk
unspecified
Other All
: Normal normal
: ---
Assigned To: Li Yuan
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-13 17:42 UTC by Cosimo Cecchi
Modified: 2012-09-13 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
atk-adaptor: plug some refcount leaks (1.94 KB, patch)
2012-09-13 17:42 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-09-13 17:42:12 UTC 
See attached patch; I'm not sure how to get that specific code path executed, but I'm quite sure the patch is correct.
Comment 1 Cosimo Cecchi 2012-09-13 17:42:13 UTC 
Created attachment 224249 [details] [review]
atk-adaptor: plug some refcount leaks

cache->add_traversal holds GObject references, so when we remove/pop
items from it, we should also drop the reference, unless it's transfered
to another queue.
Comment 2 Mike Gorse 2012-09-13 20:22:26 UTC 
Comment on attachment 224249 [details] [review]
atk-adaptor: plug some refcount leaks

Yeah, that patch looks correct. Thanks.
Comment 3 Cosimo Cecchi 2012-09-13 20:40:13 UTC 
Attachment 224249 [details] pushed as d1e52eb - atk-adaptor: plug some refcount leaks