GNOME Bugzilla – Bug 683973
Splitted sentence is untranslatable
Last modified: 2012-09-14 15:14:43 UTC
The following message cannot be translated into some languages (e.g. Japanese). src/embed.js: 239 _addSystemSettingsLabel: function() { 240 let details = new Gtk.Label({ label: _("You can add your online accounts in") + 241 " <a href=\"system-settings\">" + _("System Settings") + "</a>", Splitting one sentence into some parts makes the sentence untranslatable. Please see the following i18n guideline: https://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences I know the GNOME goal to remove markup [1]. But splitting sentences should be more problematic. [1] https://live.gnome.org/GnomeGoals/RemoveMarkupInMessages
Created attachment 224253 [details] [review] embed: don't split a translatable string
Hi Jiro, thanks for the report. Would the attached patch solve the bug for you? It keeps the string split, but the main part is now "You can add your online accounts in %s", with "System Settings" being formatted into the %s. This way, you can change its position in the final string without the need to embed markup into the translation. Let me know, I am ready to ask a string freeze break for this.
(In reply to comment #2) > Hi Jiro, thanks for the report. > Would the attached patch solve the bug for you? It keeps the string split, but > the main part is now "You can add your online accounts in %s", with "System > Settings" being formatted into the %s. This way, you can change its position in > the final string without the need to embed markup into the translation. > > Let me know, I am ready to ask a string freeze break for this. Hi Cosimo, thank you. I've confirmed that the patch fixes the problem. Could you please ask a string freeze break?
I am afraid that this won't work in some languages where the case (dative in english or locative in Czech) has a different declination than the nominative case that the separate string implies. In Czech this specific example creates no problems ("Nastavení systému" in both cases), but I am extremely sure that in some other Slavic language this will be a problem. To provide an example in Czech where it wouldn't work I'm using the name of the Czech capital, the city of Prague: nominative: "Prague" = "Praha" locative (or dative in English): "in Prague" = "v Praze"
Created attachment 224287 [details] [review] embed: don't split a translatable string --- After talking a bit with Andre on IRC we think this is a better patch; it has additional comments to explain the contexts in which the strings should be translated.
Attachment 224287 [details] pushed as 4cda0b3 - embed: don't split a translatable string Pushed after i18n approval.