GNOME Bugzilla – Bug 683967
The find bar should have a close button
Last modified: 2012-09-19 21:17:21 UTC
The only way to close it atm is pressing Esc, which is really hard to discover.
Created attachment 224240 [details] [review] close.diff Need to ask RT for approval.
Comment on attachment 224240 [details] [review] close.diff Pushed as eff14b2ff36.
Closing.
Please don't! Close buttons in non-window/tab UI elements are unclear about what their effect will be. Unfocusing the find bar does the trick fine, just as in Evince. The applications that do implement a find bar close button don't even agree on which side it should be (compare Chromium and Opera vs. Firefox). In the view of consistency: Nautilus, gedit, and Documents don't have close buttons on their find bars either. The only counter example I found was Evolution.
Hrm, honestly I don't really agree that they are confusing. OTOH I've actually seen people being confused about how to close the find bar because there is no clear way to do it. I agree that Chrome/Firefox do not agree about where to put the button, but that seems a minor detail. As long as we are consistent within GNOME IMHO it will fine. In any case the design team has plans to revisit the find bars for 3.8, so probably a good time to engage with the design will be the next cycle.
(In reply to comment #5) > Hrm, honestly I don't really agree that they are confusing. OTOH I've actually > seen people being confused about how to close the find bar because there is no > clear way to do it. I agree that Chrome/Firefox do not agree about where to put > the button, but that seems a minor detail. As long as we are consistent within > GNOME IMHO it will fine. > > In any case the design team has plans to revisit the find bars for 3.8, so > probably a good time to engage with the design will be the next cycle. Fair enough. Maybe postpone this bugfix for 3.8 then? =)