After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683929 - a pair of mem leaks
a pair of mem leaks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-13 08:43 UTC by Pavel Vasin
Modified: 2012-09-17 07:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy_web_view_load_error_page: fix GtkIconInfo leak (783 bytes, patch)
2012-09-13 08:43 UTC, Pavel Vasin 		committed Details | Review
ephy-session: fix xmlChar* leak (654 bytes, patch)
2012-09-13 08:43 UTC, Pavel Vasin 		reviewed Details | Review
ephy-dialog: fix GtkBuilder leak (587 bytes, patch)
2012-09-13 08:44 UTC, Pavel Vasin 		needs-work Details | Review
ephy-session: fix xmlChar* leak v2 (672 bytes, patch)
2012-09-13 11:55 UTC, Pavel Vasin 		committed Details | Review
ephy-dialog: fix GtkBuilder leak v2 (588 bytes, patch)
2012-09-13 11:57 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-09-13 08:43:00 UTC 
see patches
Comment 1 Pavel Vasin 2012-09-13 08:43:33 UTC 
Created attachment 224200 [details] [review]
ephy_web_view_load_error_page: fix GtkIconInfo leak
Comment 2 Pavel Vasin 2012-09-13 08:43:56 UTC 
Created attachment 224201 [details] [review]
ephy-session: fix xmlChar* leak
Comment 3 Pavel Vasin 2012-09-13 08:44:21 UTC 
Created attachment 224202 [details] [review]
ephy-dialog: fix GtkBuilder leak
Comment 4 Claudio Saavedra 2012-09-13 09:02:42 UTC 
Review of attachment 224200 [details] [review]:

Looks good.
Comment 5 Claudio Saavedra 2012-09-13 09:06:34 UTC 
Review of attachment 224201 [details] [review]:

::: src/ephy-session.c
@@ +971,3 @@
 				confirm_before_recover (window, (char*) url, (char*) title);
+
+				xmlFree (title);

Can xmlFree() deal with NULL values? If so, then it looks good to commit.
Comment 6 Claudio Saavedra 2012-09-13 09:09:17 UTC 
Review of attachment 224202 [details] [review]:

::: lib/ephy-dialog.c
@@ +395,3 @@
 
+	g_object_unref (dialog->priv->builder);
+

I think you should use g_clear_object() here, since the dispose method might be called more than once.
Comment 7 Pavel Vasin 2012-09-13 11:55:29 UTC 
Created attachment 224216 [details] [review]
ephy-session: fix xmlChar* leak v2

>Can xmlFree() deal with NULL values?

In practice it can, but not guaranteed. So better avoid potential bug.
Comment 8 Pavel Vasin 2012-09-13 11:57:33 UTC 
Created attachment 224217 [details] [review]
ephy-dialog: fix GtkBuilder leak v2

>the dispose method might be called more than once

I didn't know this, thanks.
Comment 9 Claudio Saavedra 2012-09-13 13:18:57 UTC 
Review of attachment 224216 [details] [review]:

Great!
Comment 10 Claudio Saavedra 2012-09-13 13:19:37 UTC 
Review of attachment 224217 [details] [review]:

Thanks!
Comment 11 Claudio Saavedra 2012-09-13 13:19:52 UTC 
Review of attachment 224216 [details] [review]:

Great!
Comment 12 Pavel Vasin 2012-09-13 19:53:31 UTC 
Could someone commit? I don't have git account. Thanks.
Comment 13 Claudio Saavedra 2012-09-17 07:01:03 UTC 
Attachment 224200 [details] pushed as ce03b41 - ephy_web_view_load_error_page: fix GtkIconInfo leak