After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683889 - ScreenShield: Make Return key dismiss screenshield
ScreenShield: Make Return key dismiss screenshield
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-12 20:03 UTC by Ray Strode [halfline]
Modified: 2012-09-14 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: Make Return key dismiss screenshield (19.10 KB, patch)
2012-09-12 20:03 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2012-09-12 20:03:35 UTC 
A couple of people have walked up to me and asked how to get to the
unlock screen from the screen shield. This was partly addressed by
bug 682285, but all three people who asked me about this said they
tried the return key and were surprised when it didn't work.

It sort of makes sense, since the user is "enter"ing the computer or
"return"ing to it.

This commit makes enter work in addition to the existing escape key.
Comment 1 Ray Strode [halfline] 2012-09-12 20:03:37 UTC 
Created attachment 224145 [details] [review]
ScreenShield: Make Return key dismiss screenshield
Comment 2 Ray Strode [halfline] 2012-09-12 20:13:34 UTC 
(appologies for the large number of context lines in my diff, I changed git-bz to use -W with git-format-patch (show whole function in context) and I guess that doesn't work so well with javascript)
Comment 3 drago01 2012-09-12 20:47:06 UTC 
Review of attachment 224145 [details] [review]:

Makes sense.