After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683888 - Typing "t" adds a comma as first character of tag list
Typing "t" adds a comma as first character of tag list
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Tags
GIT
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-12 19:48 UTC by Paul Wellner Bou
Modified: 2012-09-28 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add comma at the end of the comma separated tag list (1.06 KB, patch)
2012-09-12 19:53 UTC, Paul Wellner Bou 		none Details | Review
Add comma at the end of the comma separated tag list (1.06 KB, patch)
2012-09-13 10:40 UTC, Paul Wellner Bou 		none Details | Review
Add comma at the end of the comma separated tag list (1.06 KB, patch)
2012-09-13 10:45 UTC, Paul Wellner Bou 		none Details | Review
Finally the correct one... (1.07 KB, patch)
2012-09-15 22:35 UTC, Paul Wellner Bou 		none Details | Review

Description Paul Wellner Bou 2012-09-12 19:48:00 UTC 
Typing "t" opens the tag entry, if not visible already. If the selected photo(s) do have (common) tags, those tags are displayed in the entry, a comma should be put at the end of this comma separated list (but is actually put at position 0) and the cursor is put at the end of the string.
Comment 1 Paul Wellner Bou 2012-09-12 19:53:33 UTC 
Created attachment 224141 [details] [review]
Add comma at the end of the comma separated tag list

Typing "t" should add a comma at the end of the comma separated list, not at first position.
Comment 2 Paul Wellner Bou 2012-09-13 10:40:48 UTC 
Created attachment 224208 [details] [review]
Add comma at the end of the comma separated tag list

Typing "t" should add a comma at the end of the comma separated list,
not at first position.

There was an error in the first patch not declaring an int. Fixed in this one.
Comment 3 Paul Wellner Bou 2012-09-13 10:45:08 UTC 
Created attachment 224210 [details] [review]
Add comma at the end of the comma separated tag list

Typing "t" should add a comma at the end of the comma separated list,
not at first position.

There was an error in the first patch not declaring an int. Fixed in this one.
Comment 4 Paul Wellner Bou 2012-09-13 10:47:45 UTC 
My connection hung, so I resubmitted and uploaded the patch twice. Sorry.
Comment 5 Paul Wellner Bou 2012-09-15 22:35:18 UTC 
Created attachment 224427 [details] [review]
Finally the correct one...
Comment 6 Stephen Shaw 2012-09-28 08:02:01 UTC 
Awesome.  Thanks for the patch.

Applied. commit e48a90bf5e5cdab34f137e039c350ef34bd220d4