After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683864 - Memory leak fixes
Memory leak fixes
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-12 12:03 UTC by Guillaume Desmottes
Modified: 2012-09-13 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filter_groups: don't leak the widgets list (1.20 KB, patch)
2012-09-12 12:15 UTC, Guillaume Desmottes 		committed Details | Review
connection-aggregator: fix contacts array leak (930 bytes, patch)
2012-09-12 12:15 UTC, Guillaume Desmottes 		committed Details | Review
empathy_roster_model_get_groups_for_individual: return a (transfer full) list (2.81 KB, patch)
2012-09-12 12:15 UTC, Guillaume Desmottes 		committed Details | Review
theme-adium: fix priv->variant leak (852 bytes, patch)
2012-09-12 13:42 UTC, Guillaume Desmottes 		committed Details | Review
theme-adium: free the result of g_strsplit with g_strfreev (1.27 KB, patch)
2012-09-12 13:42 UTC, Guillaume Desmottes 		committed Details | Review
empathy-contact: fix priv->logged_alias leak (753 bytes, patch)
2012-09-12 13:42 UTC, Guillaume Desmottes 		committed Details | Review
individual-menu: fix GeeIterator leak (1.01 KB, patch)
2012-09-12 13:42 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-09-12 12:03:40 UTC 
.
Comment 1 Guillaume Desmottes 2012-09-12 12:15:05 UTC 
Created attachment 224097 [details] [review]
filter_groups: don't leak the widgets list
Comment 2 Guillaume Desmottes 2012-09-12 12:15:08 UTC 
Created attachment 224098 [details] [review]
connection-aggregator: fix contacts array leak
Comment 3 Guillaume Desmottes 2012-09-12 12:15:10 UTC 
Created attachment 224099 [details] [review]
empathy_roster_model_get_groups_for_individual: return a (transfer full) list

gee_iterator_get() returns a new string, so we have to pass its ownership to
the list to not leak it.
Comment 4 Guillaume Desmottes 2012-09-12 13:35:30 UTC 
Attachment 224097 [details] pushed as 0dea719 - filter_groups: don't leak the widgets list
Attachment 224098 [details] pushed as 6fbef3a - connection-aggregator: fix contacts array leak
Attachment 224099 [details] pushed as 616f55e - empathy_roster_model_get_groups_for_individual: return a (transfer full) list
Comment 5 Guillaume Desmottes 2012-09-12 13:42:51 UTC 
Created attachment 224111 [details] [review]
theme-adium: fix priv->variant leak
Comment 6 Guillaume Desmottes 2012-09-12 13:42:53 UTC 
Created attachment 224112 [details] [review]
theme-adium: free the result of g_strsplit with g_strfreev

Freeing with g_free() doesn't free the content of the array.
Comment 7 Guillaume Desmottes 2012-09-12 13:42:56 UTC 
Created attachment 224113 [details] [review]
empathy-contact: fix priv->logged_alias leak
Comment 8 Guillaume Desmottes 2012-09-12 13:42:59 UTC 
Created attachment 224114 [details] [review]
individual-menu: fix GeeIterator leak
Comment 9 Guillaume Desmottes 2012-09-13 08:16:03 UTC 
Attachment 224111 [details] pushed as e90a360 - theme-adium: fix priv->variant leak
Attachment 224112 [details] pushed as cb3a9fd - theme-adium: free the result of g_strsplit with g_strfreev
Attachment 224113 [details] pushed as 61a7bd3 - empathy-contact: fix priv->logged_alias leak
Attachment 224114 [details] pushed as 9bce1c2 - individual-menu: fix GeeIterator leak