Bug 683854 – empathy-utils.c:568: empathy_account_manager_get_accounts_connected called before AccountManager ready

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 683854 - empathy-utils.c:568: empathy_account_manager_get_accounts_connected called before AccountManager ready


Summary:	empathy-utils.c:568: empathy_account_manager_get_accounts_connected called be...


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	General
Version:	2.33.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-09-12 08:37 UTC by Guillaume Desmottes
Modified:	2012-09-12 08:51 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
empathy_roster_window_init: don't call set_notebook_page() (1.04 KB, patch) 2012-09-12 08:49 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2012-09-12 08:37:42 UTC

I  get this warning when starting master:

(lt-empathy:6771): empathy-CRITICAL **: empathy-utils.c:568: empathy_account_manager_get_accounts_connected called before AccountManager ready


0  0x00007ffff3e18c24 in g_logv (log_domain=0x7ffff7af124f "empathy", log_level=G_LOG_LEVEL_CRITICAL, 
    format=0x7ffff7af1d40 "empathy-utils.c:568: %s called before AccountManager ready", args=0x7fffffffc828) at gmessages.c:967

+ Trace 230842

#1 g_log
at gmessages.c line 1003
#2 empathy_account_manager_get_accounts_connected
at empathy-utils.c line 568
#3 set_notebook_page
at empathy-roster-window.c line 1493
#4 empathy_roster_window_init
at empathy-roster-window.c line 2277
#5 g_type_create_instance
at gtype.c line 1890
#6 g_object_constructor
at gobject.c line 1854
#7 empathy_roster_window_constructor
at empathy-roster-window.c line 1683
#8 g_object_newv
at gobject.c line 1718
#9 g_object_new_valist
at gobject.c line 1835
#10 g_object_new
at gobject.c line 1550
#11 empathy_roster_window_new
at empathy-roster-window.c line 2283
#12 empathy_app_command_line
at empathy.c line 353
#13 ffi_call_unix64
from /lib64/libffi.so.5
#14 ffi_call
from /lib64/libffi.so.5
#15 g_cclosure_marshal_generic_va
at gclosure.c line 1550
#16 g_type_class_meta_marshalv
at gclosure.c line 997
#17 _g_closure_invoke_va
at gclosure.c line 840
#18 g_signal_emit_valist
at gsignal.c line 3211
#19 g_signal_emit
at gsignal.c line 3356
#20 g_application_run
at gapplication.c line 1584
#21 main
at empathy.c line 847

Comment 1 Guillaume Desmottes 2012-09-12 08:49:33 UTC

Created attachment 224076 [details] [review]
empathy_roster_window_init: don't call set_notebook_page()

We should wait for the AM to be prepared (which is done in this function)
before calling set_notebook_page() as it calls
empathy_account_manager_get_accounts_connected() which relies on the AM being
prepared.

Comment 2 Guillaume Desmottes 2012-09-12 08:51:51 UTC

Attachment 224076 [details] pushed as 873b2ab - empathy_roster_window_init: don't call set_notebook_page()