After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683831 - Window titles for 3.6
Window titles for 3.6
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-11 23:02 UTC by David Zeuthen (not reading bugmail)
Modified: 2012-09-13 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rolled up patch (30.93 KB, patch)
2012-09-11 23:04 UTC, David Zeuthen (not reading bugmail) 		none Details | Review

Description David Zeuthen (not reading bugmail) 2012-09-11 23:02:10 UTC 
In GNOME 3.6 the window manager now displays window titles even if the dialog is transient for its parent window (In GNOME 3.0 through 3.4 the WM displayed the window as a sheet - e.g. without the window title). As no name has been set for the window, the window manager now simply shows "gnome-disks" which is not very friendly. The fix is simply to give the window a meaningful title.
Comment 1 David Zeuthen (not reading bugmail) 2012-09-11 23:04:06 UTC 
Created attachment 224057 [details] [review]
Rolled up patch

Here's a patch that does this. I have this as separate patches - this is a rolled up patch.
Comment 2 David Zeuthen (not reading bugmail) 2012-09-11 23:07:01 UTC 
Note that only five new strings are added

 Benchmark
 Drive Settings
 Encryption Options
 Mount Options
 SMART Data
Comment 3 David Zeuthen (not reading bugmail) 2012-09-11 23:09:28 UTC 
Since we're in string freeze for 3.6, requesting permission to add the five new strings mentioned in comment 2. Thanks.
Comment 4 David Zeuthen (not reading bugmail) 2012-09-13 15:32:27 UTC 
Pushed all the patches after approval. Closing