After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683818 - Need to pick up new Mesa strings
Need to pick up new Mesa strings
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: GLX
1.10.x
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-11 18:31 UTC by Alexander Larsson
Modified: 2012-09-12 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that handles the new strings (831 bytes, patch)
2012-09-11 18:31 UTC, Alexander Larsson 		none Details | Review

Description Alexander Larsson 2012-09-11 18:31:19 UTC 
Created attachment 224037 [details] [review]
Patch that handles the new strings

I'm running mesa 8.1 here and cogl (1.10) doesn't correctly pick up the vendor and the architecture (swrast).

Attaching a patch that fixes it.
Comment 1 Emmanuele Bassi (:ebassi) 2012-09-11 21:15:07 UTC 
Review of attachment 224037 [details] [review]:

just a comment, passing by...

::: cogl/cogl-gpu-info.c
@@ +217,3 @@
 check_swrast_architecture (const CoglGpuInfoStrings *strings)
 {
+  return match_phrase (strings->renderer_string, "software rasterizer") ||

I wonder if match_phrase() shouldn't just to a lc() on the string to match.
Comment 2 Robert Bragg 2012-09-12 14:24:15 UTC 
thanks I've pushed this to master, and I can cherry pick it to the cogl-1.12 branch for the next developer snapshot.

I kept the patch as is, but as ebassi suggests, if we see more examples where only the case has changed we should consider using a case in-sensitive comparison.

thanks