GNOME Bugzilla – Bug 683796
ephy-web-view: do not store internal uris in the history
Last modified: 2012-09-17 18:31:08 UTC
Chrome doesn't store these addresses in the history, and we don't want them to show up in the history window nor the overview. Let's just stop storing them already. I am not sure if we need a migration patch to remove already existing visits to these pages, but let's just blacklist them already for now.
Created attachment 224022 [details] [review] ephy-web-view: do not store internal uris in the history about:// and ephy-about:// have no place in the history. Let's just blacklist them already.
Created attachment 224236 [details] [review] ephy-embed-utils: add ephy_embed_utils_is_no_show_address()
Created attachment 224237 [details] [review] ephy-web-view: do not save history visits for no-show-addresses We don't show these addresses in the location entry because they are very special to epiphany. There is no reason to store them in the history.
Review of attachment 224236 [details] [review]: OK. ::: embed/ephy-embed-utils.c @@ +178,3 @@ + for (i = 0; do_not_show_address[i]; i++) + if (g_str_equal (address, do_not_show_address[i])) + return TRUE; This is one statement but two lines, so let's use {} please!
Review of attachment 224237 [details] [review]: Why not freeze the history instead of adding an extra check?
Created attachment 224499 [details] [review] ephy-web-view: do not save history visits for no-show-addresses We don't show these addresses in the location entry because they are very special to epiphany. There is no reason to store them in the history.
Created attachment 224500 [details] [review] ephy-web-view: freeze history on homepage load And remove redundant check.
Review of attachment 224499 [details] [review]: OK.
Review of attachment 224500 [details] [review]: OK, but seems is_loading_homepage is unused now (as a method). So maybe just kill it too.
(In reply to comment #9) > Review of attachment 224500 [details] [review]: > > OK, but seems is_loading_homepage is unused now (as a method). So maybe just > kill it too. I didn't kill it yet because it's "private" API, but it's actually unused, so...
Created attachment 224525 [details] [review] ephy-web-view: remove ephy_web_view_is_loading_homepage() It's unused and its usage is redundant with the ephy_web_view_is_history_frozen()
Attachment 224236 [details] pushed as fcb0f32 - ephy-embed-utils: add ephy_embed_utils_is_no_show_address() Attachment 224499 [details] pushed as 9d8795a - ephy-web-view: do not save history visits for no-show-addresses Attachment 224500 [details] pushed as 009c776 - ephy-web-view: freeze history on homepage load Attachment 224525 [details] pushed as 0b1ef33 - ephy-web-view: remove ephy_web_view_is_loading_homepage()