After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683790 - daemon: export a Version on the bus
daemon: export a Version on the bus
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-11 10:33 UTC by Giovanni Campagna
Modified: 2012-09-14 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: export a Version on the bus (2.78 KB, patch)
2012-09-11 10:33 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-09-11 10:33:44 UTC 
This will allow clients such as gnome-shell to do runtime detection
of gdm and fallback gracefully if not available.
Comment 1 Giovanni Campagna 2012-09-11 10:33:47 UTC 
Created attachment 224008 [details] [review]
daemon: export a Version on the bus
Comment 2 Ray Strode [halfline] 2012-09-14 15:47:59 UTC 
Review of attachment 224008 [details] [review]:

Sure.

::: daemon/gdm-manager.c
@@ +1053,3 @@
 
+        gdm_dbus_manager_set_version (GDM_DBUS_MANAGER (manager), PACKAGE_VERSION);
+

This is fine, though, an alternative approach to consider would be:

"version", PACKAGE_VERSION 

in the g_object_new in gdm_manager_new.  Up to you.

::: daemon/gdm-manager.h
@@ +46,3 @@
 typedef struct
 {
+        GdmDBusManagerSkeletonClass parent_class;

the changes in this file should be in their own commit
Comment 3 Giovanni Campagna 2012-09-14 15:58:12 UTC 
Attachment 224008 [details] pushed as d73f46f - daemon: export a Version on the bus