After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683771 - First argument (bus_name) of g_dbus_connection_call_sync() should be NULLable
First argument (bus_name) of g_dbus_connection_call_sync() should be NULLable
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 681093
 
 
Reported: 2012-09-11 05:33 UTC by Thomas Bechtold
Modified: 2012-09-11 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Example to test the behavior (940 bytes, text/x-python)
2012-09-11 05:33 UTC, Thomas Bechtold
  Details
Fix Annotations (1.62 KB, patch)
2012-09-11 05:48 UTC, Thomas Bechtold
committed Details | Review
Example to test the behavior (942 bytes, text/x-python)
2012-09-11 06:00 UTC, Thomas Bechtold
  Details

Description Thomas Bechtold 2012-09-11 05:33:13 UTC
Created attachment 223985 [details]
Example to test the behavior

This is needed to be able setup a peer-to-peer connection. See attachment for an example.
Comment 1 Martin Pitt 2012-09-11 05:36:21 UTC
The current documentation (and annotation) do not point out that bus_name can be NULL. The asynchronous variant g_dbus_connection_call() does, though.
Comment 2 Thomas Bechtold 2012-09-11 05:48:31 UTC
Created attachment 223986 [details] [review]
Fix Annotations
Comment 3 Martin Pitt 2012-09-11 05:51:57 UTC
Comment on attachment 223986 [details] [review]
Fix Annotations

Looks good to me. However, this is just a review, not a signoff for committing, as I'm not a GLib maintainer (just a mere introspection guy).
Comment 4 Thomas Bechtold 2012-09-11 06:00:26 UTC
Created attachment 223987 [details]
Example to test the behavior

Fixes a test-script bug
Comment 5 Richard Hughes 2012-09-11 12:19:11 UTC
Review of attachment 223986 [details] [review]:

Looks good, thanks.