After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683763 - i18n - Capitalize acronyms
i18n - Capitalize acronyms
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-11 03:18 UTC by Chris Leonard
Modified: 2012-11-02 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
i18n fix (4.74 KB, patch)
2012-09-11 19:08 UTC, Chris Leonard
committed Details | Review

Description Chris Leonard 2012-09-11 03:18:52 UTC
../daemon/gvfsbackendsftp.c:299 
../daemon/gvfsbackendsftp.c:654

ssh program unexpectedly exited

should be

SSH program unexpectedly exited


../daemon/gvfsbackendsftp.c:498

Unable to spawn ssh program

should be

Unable to spawn SSH program


../daemon/gvfsbackendsftp.c:514

Unable to spawn ssh program: %s

should be

Unable to spawn SSH program: %s


../daemon/gvfsbackendsftp.c:1728

Unable to find supported ssh command

should be

Unable to find supported SSH command


../common/gvfsdnssdutils.c:233 
../common/gvfsdnssdutils.c:263 
../common/gvfsdnssdutils.c:280

Malformed dns-sd encoded_triple '%s'

should be

Malformed DNS-SD encoded_triple '%s'
Comment 1 Tomas Bzatek 2012-09-11 12:21:49 UTC
Looks good to me, could you please prepare a patch?
Comment 2 Chris Leonard 2012-09-11 19:08:14 UTC
Created attachment 224038 [details] [review]
i18n fix

Resolves #683763
Comment 3 Chris Leonard 2012-09-11 19:09:16 UTC
Patch attached above, please commit.
Comment 4 Tomas Bzatek 2012-09-12 10:35:23 UTC
Review of attachment 224038 [details] [review]:

Thanks for the patch, looks good. Holding off for the moment since we're in a string freeze period and this is rather tiny change.
Comment 5 Chris Leonard 2012-09-12 15:24:59 UTC
Absolutely.  No need to request a string freeze break for this.
Comment 6 Chris Leonard 2012-09-28 02:24:27 UTC
Since you've created a 3.6 branch, can this be landed in master?
Comment 7 Tomas Bzatek 2012-10-01 10:01:08 UTC
(In reply to comment #6)
> Since you've created a 3.6 branch, can this be landed in master?

Ah yes, please commit.
Comment 8 Felix Möller 2012-11-02 15:49:27 UTC
Could we get this commited, please.
Comment 9 Tomas Bzatek 2012-11-02 16:10:40 UTC
Committed to master.

commit 108168e6ecc0103f62b20531b9adf138935bb8a3
Author: cjl <cjlhomeaddress@gmail.com>
Date:   Fri Nov 2 17:08:53 2012 +0100

    Capitalize acronyms
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683763
    
    Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>