After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683736 - [regression] calendar work week view drops Monday's entries
[regression] calendar work week view drops Monday's entries
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
3.6.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-09-10 18:28 UTC by David Ronis
Modified: 2013-09-13 01:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (3.63 KB, patch)
2012-09-11 09:16 UTC, Milan Crha
committed Details | Review

Description David Ronis 2012-09-10 18:28:47 UTC
I'm running the git master of evo and friends on a gnome 3.5.91/slackware box.  I have my preferences set so that my week starts on Sunday and have Mon--Fri as working days.   The calendar displays as expected in single day view.   However, in work-week view, Monday's entries are missing (they appear in single day-mode).  These entries come from a mix of local and non-local calendars and two of them are from recurring appointments.

[ I thought that I'd reported something similar a while ago relating to the initial display of the work week, but can't seem to find it, and in any event, this seems different].
Comment 1 Milan Crha 2012-09-11 07:28:07 UTC
Thanks for a bug report. I can reproduce it too, thus confirming. There is a critical warning on console when switching to the Work Week mode, which is certainly causing this:
> calendar-gui-CRITICAL **: e_day_view_add_event: assertion `start < 
> add_event_data->day_view->upper' failed
Comment 2 Milan Crha 2012-09-11 08:38:47 UTC
Hrm, I caused this with my change to bug #681669.
Comment 3 Milan Crha 2012-09-11 09:16:29 UTC
Created attachment 224001 [details] [review]
evo patch

for evolution;

There were needed more places to be fixed, and I missed an inconsistency between week_day_start and EDayView::working_days. The former uses 0 Mon to 6 Sun, while the later uses 0 Sun to 6 Sat numbering, which makes things confusing. After this refix both bugs are working as expected.
Comment 4 Milan Crha 2012-09-11 09:17:45 UTC
Created commit ca8610a in evo master (3.5.92+)
Comment 5 David Ronis 2012-09-11 16:49:56 UTC
Thanks Milan.

When I 1st restarted evolution, the fix hadn't taken--worse the entire work week calendar was empty.  I think that's because an old evolution-calendar-factory was running.   I restarted and things work as expected.
Comment 6 Milan Crha 2012-09-12 05:35:22 UTC
Hmm, strange, as the fix was only for evolution, not for evolution-data-server, thus it might be something else. Maybe if you rebuilt also eds, then it made the factory confused.