GNOME Bugzilla – Bug 683722
sorting by Type should group type families
Last modified: 2012-09-15 16:09:57 UTC
When I sort the views by Type I would like to see type families grouped together. So that, for example, jpeg and png images are located near one another. Or so that various types of archives are together. I think we should probably also special case directories to appear on top.
Created attachment 223949 [details] [review] When sorting by type group into type families
Created attachment 223951 [details] [review] When sorting by type group into type families Remove spurious paste
Created attachment 223956 [details] [review] Only show basic type information in type column by default Another approach. I think I like this better because it is clearer why the items are sorted in the order they are.
Created attachment 223958 [details] [review] Only show basic type information in type column by default
Review of attachment 223958 [details] [review]: Looks fine, except for these comments below. ::: libnautilus-private/nautilus-file.c @@ +6171,3 @@ + { "text-x-generic-template", N_("Text") }, + { "text-x-script", N_("Program") }, + { "font-x-generic", N_("Font") }, This appears twice @@ +6235,3 @@ + + description = g_content_type_get_description (mime_type); + if (g_strcmp0 (description, NULL) != 0) { I know this is in the original code too, but why doing this instead of checking for description != NULL? (also below)
Comment on attachment 223951 [details] [review] When sorting by type group into type families If we use the other patch, this is not needed.
Review of attachment 223958 [details] [review]: The other thing is that this leaves us with the "Type" column using the new non-detailed MIME description, and another "Mime Type" column that uses the raw content-type string. Is that something that we want, or do you think it's better to change the more advanced column to show the old detailed description instead? (and leave the raw content-type string to the properties dialog)
Created attachment 223964 [details] [review] Only show basic type information in type column by default
(In reply to comment #7) > Review of attachment 223958 [details] [review]: > > The other thing is that this leaves us with the "Type" column using the new > non-detailed MIME description, and another "Mime Type" column that uses the raw > content-type string. Is that something that we want, or do you think it's > better to change the more advanced column to show the old detailed description > instead? (and leave the raw content-type string to the properties dialog) I'm leaning toward leaving the mime-type column in the view and possibly showing the detailed type in the properties. The mime type is much more compact.
Review of attachment 223964 [details] [review]: This looks good now, but we'll need UI and string freeze breaks.
Cool. This bug is really important to us in order that we can properly prioritize the name field in the list view, easily allow for sorting directories on top, make the type names easier to scan and compare, reduce the need for horizontal scrolling, more easily fit in a side by side mode, add a long requested feature and a very useful sorting mode to complement name sorting.
+ basic_type = g_strdup (mime_type_map[i].display_name); The inside of g_strdup() needs to be wrapped in a gettext() call to have the localized strings returned. mime_type_map is a static array, we all know what this means: http://www.gnu.org/software/gettext/manual/gettext.html#Special-cases
Created attachment 224389 [details] [review] Fix translation of type column http://www.gnu.org/software/gettext/manual/gettext.html#Special-cases
Review of attachment 224389 [details] [review]: ++