After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683703 - Orca doesn't expose any meaningful label for most of the toggle buttons
Orca doesn't expose any meaningful label for most of the toggle buttons
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Universal Access
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-10 09:07 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-09-13 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch (24.61 KB, patch)
2012-09-13 05:30 UTC, Matthias Clasen 		accepted-commit_now Details | Review
and another (6.18 KB, patch)
2012-09-13 05:30 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-09-10 09:07:50 UTC 
STEPS TO REPRODUCE

0. Precondition: Orca running
1. Open Universal Access (ie: top panel, accessibility menu, last menu item)
2. Navigate to the first toggle button (High contrast, on-of toggle button)

EXPECTED OUTCOME:

Orca exposes all the items focused: "All items push button" - "Seeing Tab" - "High contrast toggle button pressed"

ACTUAL OUTCOME

"All items push button" and "Seeing tab" exposed.
But just "Toggle button pressed" is exposed with the button, so user can't know what that toggle button is for.

NOTES:

This happens with most of the toggle buttons of any tab of the universal access. I made a quick review of other regions of gnome-control-center and seems to be fine, although probably a deep review would be good.
Comment 1 Matthias Clasen 2012-09-13 05:30:13 UTC 
Created attachment 224188 [details] [review]
a patch
Comment 2 Matthias Clasen 2012-09-13 05:30:43 UTC 
Created attachment 224189 [details] [review]
and another
Comment 3 Bastien Nocera 2012-09-13 08:58:15 UTC 
Review of attachment 224189 [details] [review]:

++
Comment 4 Bastien Nocera 2012-09-13 08:59:24 UTC 
Review of attachment 224188 [details] [review]:

Looks good other than the extraneous "use-action-appearance" changes.

::: panels/universal-access/uap.ui
@@ +612,3 @@
                             <property name="can_focus">True</property>
                             <property name="halign">end</property>
+                            <property name="use_action_appearance">False</property>

Could you remove those unrelated changes?
Comment 5 Matthias Clasen 2012-09-13 09:59:06 UTC 
glade puts those in; they're hard to avoid. I'll see if I can remove them