After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683614 - Phase out usage of 'embed_shell' and 'ephy_shell' globals
Phase out usage of 'embed_shell' and 'ephy_shell' globals
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-08 10:23 UTC by Xan Lopez
Modified: 2012-12-10 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-embed-shell: remove the embed_shell global (18.79 KB, patch)
2012-12-10 16:57 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
ephy-shell: remove the ephy_shell global (26.85 KB, patch)
2012-12-10 16:57 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Xan Lopez 2012-09-08 10:23:33 UTC 
- Using global variables is generally wrong.

- We have accessor functions for these.

- I think a sane way of implementing Private Mode would be to create a EphyPrivateShell (or something) and create a new EphyWebView that uses this. The shell would take care of changing the paths so that we don't use the main cookies, bookmarks, history, etc. It will be much easier to do this if we don't access the shell through the global variables.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 16:57:13 UTC 
Created attachment 231166 [details] [review]
e-embed-shell: remove the embed_shell global
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 16:57:17 UTC 
Created attachment 231167 [details] [review]
ephy-shell: remove the ephy_shell global
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-12-10 17:12:21 UTC 
Will open another bug for the work you suggested on EphyWebView.

Attachment 231166 [details] pushed as e65754d - e-embed-shell: remove the embed_shell global
Attachment 231167 [details] pushed as 533c348 - ephy-shell: remove the ephy_shell global