After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683598 - Add an icon to the location entry and drop use of location bar
Add an icon to the location entry and drop use of location bar
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-07 22:39 UTC by William Jon McCann
Modified: 2012-09-10 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an icon to the location entry and drop use of location bar (44.14 KB, patch)
2012-09-07 22:39 UTC, William Jon McCann 		accepted-commit_after_freeze Details | Review
Add an icon to the location entry and drop use of location bar (43.97 KB, patch)
2012-09-09 22:41 UTC, William Jon McCann 		committed Details | Review
screenshot before (38.11 KB, image/png)
2012-09-10 12:52 UTC, Cosimo Cecchi 		  Details
screenshot after (36.70 KB, image/png)
2012-09-10 12:52 UTC, Cosimo Cecchi 		  Details

Description William Jon McCann 2012-09-07 22:39:29 UTC 
The location bar doesn't do much except add a label next to the entry. This
label is problematic because it takes valuable space away from the entry
and isn't consistent with other location bars we use in GNOME 3 (eg. Web).
Comment 1 William Jon McCann 2012-09-07 22:39:31 UTC 
Created attachment 223794 [details] [review]
Add an icon to the location entry and drop use of location bar
Comment 2 Cosimo Cecchi 2012-09-09 20:40:56 UTC 
Review of attachment 223794 [details] [review]:

With the exception of the following comment, this looks good to me, assuming the DnD code was moved unchanged between NautilusLocationBar and NautilusLocationEntry.
If we want to get this in for 3.6 we'll need to ask for an UI freeze break though, since we are changing the label with an icon in the bar.

::: src/nautilus-location-entry.c
@@ +190,3 @@
+void
+nautilus_location_entry_set_location (NautilusLocationEntry *entry,
+	last_location = g_file_parse_name (entry->details->last_location);

I'd rather this be called set_uri() instead; we commonly use locations for GFile objects.
Comment 3 William Jon McCann 2012-09-09 22:41:10 UTC 
Created attachment 223870 [details] [review]
Add an icon to the location entry and drop use of location bar
Comment 4 Cosimo Cecchi 2012-09-10 12:52:12 UTC 
Created attachment 223905 [details]
screenshot before
Comment 5 Cosimo Cecchi 2012-09-10 12:52:31 UTC 
Created attachment 223906 [details]
screenshot after
Comment 6 Cosimo Cecchi 2012-09-10 13:01:19 UTC 
Review of attachment 223870 [details] [review]:

++
Comment 7 William Jon McCann 2012-09-10 13:52:51 UTC 
Attachment 223870 [details] pushed as cbcb055 - Add an icon to the location entry and drop use of location bar